Not properly unit testing nova.servers_set_meta

Bug #1665594 reported by Carlos Goncalves
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
Undecided
Carlos Goncalves

Bug Description

The unit test for nova_servers_set_meta is not testing the nova datasource method itself but rather testing the DataSourceDriver.execute() method.

The fix should be very similar to the unit test code in commit daca060c304574d111c8fc1b09713b2b05a875fc / Change-Id Id1bc631d1d301a990ae2618e3d081b9b926e1c55

Changed in congress:
assignee: nobody → Carlos Goncalves (cgoncalves)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/435341

Changed in congress:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/435341
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=d76057271aab5626d28930691856b1d2d5e1b1f9
Submitter: Jenkins
Branch: master

commit d76057271aab5626d28930691856b1d2d5e1b1f9
Author: Carlos Goncalves <email address hidden>
Date: Fri Feb 17 09:49:10 2017 +0000

    Fix nova.servers_set_meta unit test

    The unit test for nova_servers_set_meta was not testing the nova
    datasource method itself but rather testing the
    DataSourceDriver.execute() method.

    Also, align the format of arguments and description of the
    nova.servers_set_meta method with commit
    daca060c304574d111c8fc1b09713b2b05a875fc.

    Closes-Bug: #1665594
    Change-Id: Ibd78e62351bfbd07b20db746c8cb0a5ced40e2f9

Changed in congress:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/congress 6.0.0.0b1

This issue was fixed in the openstack/congress 6.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.