congress

500 error on get of non-existent policy

Bug #1621268 reported by Eric K
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
congress
Fix Committed
Medium
Pallavi
congress newton-rc2

Bug Description

http get on a non-existent policy say /v1/policies/no-such-policy causes 500 error. Should be 404.

Eric K (ekcs)
Changed in congress:
milestone: none → newton-rc1
Eric K (ekcs)
description: updated
Changed in congress:
assignee: Eric K (ekcs) → nobody
Pallavi (pallavi-s)
Changed in congress:
assignee: nobody → Pallavi (pallavi-s)
Revision history for this message
Eric K (ekcs) wrote :

Thanks Pallavi!
I submitted a patch for the error on get. Same fix needed on delete and maybe other operations.
https://review.openstack.org/#/c/367090/

Changed in congress:
importance: Undecided → Medium
Anusha (anusha-iiitm)
Changed in congress:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/367090
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=f717711ed2669f66c1d88c39354e080761cc3eb4
Submitter: Jenkins
Branch: master

commit f717711ed2669f66c1d88c39354e080761cc3eb4
Author: Eric K <email address hidden>
Date: Wed Sep 7 22:50:48 2016 -0700

    give correct http error on getting non-existent policy

    Catch internal error and translate into proper webservice exception
    Avoids error 500

    Change-Id: I40c55daff70f92d0a37c5d0d9868546c78c6cf0e
    partial-bug: 1621268

Revision history for this message
Eric K (ekcs) wrote :

Hi Pallavi!

Thanks for working on this bug!

As Newton-RC1 deadline is this week, it would be great to have this bug resolved. Do you expect to have time for this bug this week?

If not, please feel free to let me know and have me finish the fix. Thanks again and sorry about the rush!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/370738

Changed in congress:
status: Confirmed → In Progress
Eric K (ekcs)
Changed in congress:
milestone: newton-rc1 → newton-rc2
Eric K (ekcs)
description: updated
Changed in congress:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on congress (master)

Change abandoned by Tim Hinrichs (<email address hidden>) on branch: master
Review: https://review.openstack.org/370738
Reason: Seems the patch is unnecessary, and no activity for 1+ months. Can always restore.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.