HAHT - Update synchronizer for distributed deployment

[Eric K]

Currently datasource synchronizer is built for synchronizing single-node replicas. It does not work for distributed deployment (would try to add datasources to every node, including nodes not intended to have datasource services).

The next time sync is triggered on node2, it keeps the old ds named 'dsname'. Proper behavior should be to update to the new ds on node2. What we need to do is to base sync on UUID (maybe plus other info) rather than name in ds sync.

Please see spec and blueprint for more information.
https://github.com/openstack/congress-specs/blob/master/specs/newton/high-availability-design.rst
https://blueprints.launchpad.net/congress/+spec/high-availability-design

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/354629

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/354629
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=7a1c65b3d9ee5c965fb7606e51beb24a25700ec8
Submitter: Jenkins
Branch: master

commit 7a1c65b3d9ee5c965fb7606e51beb24a25700ec8
Author: Anusha Ramineni <email address hidden>
Date: Thu Aug 11 10:58:17 2016 +0530

    Sync datasources only on datasource node

    Closes-Bug:#1612008
    Change-Id: Ie20302d42ea06b912b0e89e3cabe8c3363cab88a

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/congress 4.0.0.0b3 development milestone.

[Eric K (ekcs)]

Re-opening bug because outside of add_datasource, the synchronize_datasources method is still executed and on non-datasource nodes and attempt to create/remove datasource services on those nodes. It is still executed on delete_datasource (https://github.com/openstack/congress/blob/master/congress/dse2/dse_node.py#L860) and on and on the periodically called task (https://github.com/openstack/congress/blob/master/congress/dse2/dse_node.py#L612)

Proposed new fix:
Move the `if cfg.CONF.datasources:` (https://github.com/openstack/congress/blob/master/congress/dse2/dse_node.py#L748) check to inside the synchronize_datasources method rather than each time the method is called.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/395875

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/395875
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=ac81b91f55cbdb177cc6de8fd05fd579250e2a49
Submitter: Jenkins
Branch: stable/newton

commit ac81b91f55cbdb177cc6de8fd05fd579250e2a49
Author: Eric K <email address hidden>
Date: Mon Nov 7 11:32:19 2016 -0800

    Sync-datasources only on datasource nodes

    Fixes the problem that datasources are created and
    sync'ed an non-datasource nodes.

    Change-Id: I2fdbf4c75d9cd75cb9bf7893504dbfb13448c9c3
    Closes-Bug: 1612008

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/394598
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=1b956eba2354eb20169c77686c0d4456d71e40e0
Submitter: Jenkins
Branch: master

commit 1b956eba2354eb20169c77686c0d4456d71e40e0
Author: Eric K <email address hidden>
Date: Mon Nov 7 11:32:19 2016 -0800

    Sync-datasources only on datasource nodes

    Fixes the problem that datasources are created and
    sync'ed an non-datasource nodes.

    Closes-Bug: 1612008

    Change-Id: I2fdbf4c75d9cd75cb9bf7893504dbfb13448c9c3

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/congress 5.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/congress 4.0.1 release.