tests repeated due to inheritance in tests2/test_congress.py

Bug #1595791 reported by Eric K
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
Low
Aimee Ukasick

Bug Description

Many tests in tests2/test_congress.py are unnecessarily repeated because TestPolicyExecute inherits from TestCongress and hence all the methods/tests.

Suggested resolution: make the two classes independent (neither one inheriting from the other)

class TestPolicyExecute(TestCongress):
    def setUp(self):
        super(TestPolicyExecute, self).setUp()
        self.nova = self._register_test_datasource('nova')

Changed in congress:
assignee: nobody → Rebecca Finn (rebeccax-finn)
Changed in congress:
assignee: Rebecca Finn (rebeccax-finn) → nobody
Aimee Ukasick (aimeeu)
Changed in congress:
assignee: nobody → Aimee Ukasick (aimeeu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/337880

Changed in congress:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/337880
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=c451d0e80ac0b9cf124aca0646577db0a6810baa
Submitter: Jenkins
Branch: master

commit c451d0e80ac0b9cf124aca0646577db0a6810baa
Author: aimee.ukasick <email address hidden>
Date: Tue Jul 5 15:53:24 2016 -0500

    TestPolicyExecute no longer inherits from TestCongress

    Removed TestPolicyExecute's inheritence from TestCongress. Removed the
    common attributes and method needed to run both classes' tests from
    TestCongress into a superclass. Both TestCongress and TestPolicyExecute
    extend the new superclass.

    Closes-Bug#: 1595791

    Change-Id: I1841b6567848da712f4815cf93efc6e78155f030

Changed in congress:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.