congress does not respect devstack branch

Bug #1503353 reported by Tim Hinrichs
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
congress
Fix Released
Low
Madhu Mohan Nelemane

Bug Description

To run all the openstack projects for a given branch B such as stable/liberty, you simply do a git-checkout -b B within devstack before running stack.sh. This causes devstack to run git clone ... -b B for every project it installs.

When following the devstack install instructions for Congress but cloning devstack with -b B, the B branch is not checked out for Congress; instead master is checked out.

I suspect devstack provides the B branch as an environmental variable (or something similar), and the congress contrib/devstack scripts do not properly deal with that variable.

Tags: liberty-rc2
Tim Hinrichs (thinrichs)
Changed in congress:
importance: Medium → Low
Revision history for this message
Tim Hinrichs (thinrichs) wrote :

It seems we are using the CONGRESS_BRANCH as we should be doing. But it seems it doesn't get properly set.

I'm told on #openstack-infra that the gate will do the proper thing, so mainly this is a problem for end users trying to check out the stable/liberty branch via devstack.

Revision history for this message
Tim Hinrichs (thinrichs) wrote :

I tried setting CONGRESS_BRANCH to DEVSTACK_BRANCH, but no luck

Revision history for this message
Tim Hinrichs (thinrichs) wrote :

I added a release note in case we can't fix the problem.

Revision history for this message
Tim Hinrichs (thinrichs) wrote :

It seems that we're being forced to create a devstack plugin for the next release since the copy/paste version will no longer be supported.

Changed in congress:
assignee: nobody → shravya Gaddam (shravya-g90)
Changed in congress:
assignee: shravya Gaddam (shravya-g90) → nobody
Changed in congress:
assignee: nobody → Madhu Mohan Nelemane (mmohan-9)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/289990

Changed in congress:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/289990
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=6a2a623f0b4e953f070d6ad06bf799be595bbd73
Submitter: Jenkins
Branch: master

commit 6a2a623f0b4e953f070d6ad06bf799be595bbd73
Author: Madhu Mohan Nelemane <email address hidden>
Date: Tue Mar 8 16:52:04 2016 +0100

    Fix use of devstack-based branch for congress

    Devstack uses the github URL provided in local.conf.
    Doing stack.sh does checkout the relevant branch.
    plugin.sh need not explicitly checkout the branch. The plugin can
    install only the congressclient and any other dependencies
    (like java-jre) from the script.
    Also adding a README.rst for enabling the plugin for devstack.

    Change-Id: I3daacfbbedf067392410535820f364e788905fe4
    Closes-Bug: #1503353

Changed in congress:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/congress 3.0.0.0rc1

This issue was fixed in the openstack/congress 3.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.