Nova client fails to load

[Tim Hinrichs]

Presumably because of a new version of the nova client, the nova client is failing to load. This causes test failures.

e.g. congress.tests.test_congress.TestCongress.test_startup

d6cage:: Error loading service 'nova' of module '<module 'datasources_nova_driver_py' from '/Users/tim/opencode/congress/congress/datasources/nova_driver.pyc'>'::
Traceback (most recent call last):
  File "congress/dse/d6cage.py", line 269, in createservice
    args)
  File "/Users/tim/opencode/congress/congress/datasources/nova_driver.py", line 28, in d6service
    return NovaDriver(name, keys, inbox, datapath, args)
  File "/Users/tim/opencode/congress/congress/datasources/nova_driver.py", line 136, in __init__
    'novaclient.v2.')
  File "congress/datasources/datasource_utils.py", line 108, in inspect_methods
    if ((p not in obj_checked) and
  File "/Users/tim/opencode/congress/.tox/py27/lib/python2.7/site-packages/novaclient/api_versions.py", line 99, in __eq__
    "cls": self.__class__})
TypeError: '<novaclient.v2.client.Client object at 0x110b343d0>' should be an instance of '<class 'novaclient.api_versions.APIVersion'>'
}}}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220334

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tim Hinrichs (<email address hidden>) on branch: master
Review: https://review.openstack.org/220334
Reason: Had to be rolled into another fix, so all the tests will pass.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/220700
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=65b59ea54c30511290a4a9810020964d76d981b0
Submitter: Jenkins
Branch: master

commit 65b59ea54c30511290a4a9810020964d76d981b0
Author: Tim Hinrichs <email address hidden>
Date: Fri Sep 4 16:39:51 2015 -0700

    Unbreak master with 2 fixes in 1 commit

    1. Avoid double-use of 'name' value in exceptions

    Previously the Congress Exception used 'name' as the name of
    the error code to use and some of its subclasses used 'name'
    as a placeholder in the error message. This caused problems
    because CongressException popped 'name' off the keyword args
    in the super class, which meant it was unavailable during
    message construction. This was causing congress to fail
    to start in devstack.

    This change eliminates the use of 'name' in the subclasses.

    2. Fix nova datasource driver instantiation failure

    The nova client failed to load because an equality check
    on nova client was raising an exception. This was causing
    all unit tests using nova to fail.

    This fix replaces an implicit == check with an 'is' check.

    Closes-bug: 1492334
    Closes-bug: 1492051
    Change-Id: I8c166cd4db6d4c45d0709cb33a16bc3188d3d5eb