Forever subscribe attempts of deepsix

Bug #1475531 reported by Yingxin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
Undecided
Yingxin

Bug Description

When subscribing dataindex/tables from services, the deepsix.schedule() will send 'sub' messages periodically to make sure the subscriptions are successful.

However, the attempts to subscribe will continue forever even after they succeed. So dsebus will be filled with 'sub' messages if there are lots of services and policy rules. Unnecessary routing works of d6cage will introduce additional workloads.

Yingxin (cyx1231st)
Changed in congress:
assignee: nobody → Yingxin (cyx1231st)
Revision history for this message
Rui Chen (kiwik-chenrui) wrote :

Append patch links:

    https://review.openstack.org/#/c/202922/

Changed in congress:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/202922
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=89bd1ab03a39dc40d01668b73061515a53038c7a
Submitter: Jenkins
Branch: master

commit 89bd1ab03a39dc40d01668b73061515a53038c7a
Author: Yingxin Cheng <email address hidden>
Date: Fri Jul 17 16:18:52 2015 +0800

    Stop subscribe attempts after successfully handled

    The 'sub' message will be handled by 'insub()' in publish service. If
    `msg.correlationId` is already in target service's
    subscriberCorrelationUuids list, additional message with the same corrId
    will be simply ignored. So forever subscribe attempts are unnecessary.

    Every successful subscription is replied by a 'pub' message with the
    same correlationId of the corresponding 'sub' message. So if the
    subscriber receives a 'pub' message, it can stop the related subscribe
    attempts by deleting the id from scheduuids.

    Change-Id: Ifd0c68c74c8589a594337fc942088488e2d53fff
    Closes-Bug: #1475531

Changed in congress:
status: In Progress → Fix Committed
Tim Hinrichs (thinrichs)
Changed in congress:
milestone: none → liberty-2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.