Congress tests import fakes from novaclient

Bug #1364515 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
Undecided
Unassigned

Bug Description

Currently in a few places in the code the congress unit tests import fakes from the novaclient (congress/datasources/tests/unit/fakes.py) this is dangerous because what we are importing is not a stable interface that is being maintained and can be changed at any moment breaking us. In fact the novaclient added new imports to testscenarios to this file which we didn't have in our test-requirements which ended up breaking the congress gate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/119734
Committed: https://git.openstack.org/cgit/stackforge/congress/commit/?id=ef2f6f6931d213366568032d04d466d54c890823
Submitter: Jenkins
Branch: master

commit ef2f6f6931d213366568032d04d466d54c890823
Author: ubuntu <email address hidden>
Date: Mon Sep 8 04:18:04 2014 -0700

    Replace fakes.FakeClient inheritence with Mock

    NovaFakeClient had fakes.FakeClient as a super classes.

    This dependency broke the build as the interface was not
    well defined

    Replace the super classe FakeClient with MagicMock and implement
    the local return types as mock object

    Closes-bug: 1364515
    Change-Id: I746daf38f985eba824a5a0759f450766b08b2dab

Changed in congress:
status: New → Fix Committed
Tim Hinrichs (thinrichs)
Changed in congress:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.