Port provider mappings handling issue

Bug #1845480 reported by Lucian Petrut on 2019-09-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
compute-hyperv
Undecided
Lucian Petrut

Bug Description

"migrate_instance_finish" now accepts a mapping between port ids and resource providers as per I220fa02ee916728e241503084b14984bab4b0c3b. This is required in order to support port QoS specs leveraging Placement allocations.

The compute-hyperv cluster driver doesn't currently pass this argument when handling failovers, which breaks the gate.

Fix proposed to branch: master
Review: https://review.opendev.org/685034

Changed in compute-hyperv:
assignee: nobody → Lucian Petrut (petrutlucian94)
status: New → In Progress

Reviewed: https://review.opendev.org/685034
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=40bd35fcc2d9aecba490a88230f9e7302e6d59c1
Submitter: Zuul
Branch: master

commit 40bd35fcc2d9aecba490a88230f9e7302e6d59c1
Author: Lucian Petrut <email address hidden>
Date: Thu Sep 26 13:33:23 2019 +0300

    Pass missing arg to "migrate_instance_finish"

    This method now accepts a mapping between port ids and resource
    providers as per I220fa02ee916728e241503084b14984bab4b0c3b.

    We'll need to figure how exactly should this dict look like.
    Meanwhile, we'll just pass "None", which Nova seems to accept
    for backwards compatibility reasons.

    This is a temporary workaround meant to unblock the gate. It will
    have to be properly handled by the time we release Ussuri, otherwise
    we won't be able to support port QoS.

    Change-Id: I878eab9615a76edab0f8ae5bb0d16652baae473a
    Partial-Bug: #1845480

Reviewed: https://review.opendev.org/685058
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=9b8ebe053b0913a0649fb8e76ca7e8b3a6f655dd
Submitter: Zuul
Branch: stable/train

commit 9b8ebe053b0913a0649fb8e76ca7e8b3a6f655dd
Author: Lucian Petrut <email address hidden>
Date: Thu Sep 26 13:33:23 2019 +0300

    Pass missing arg to "migrate_instance_finish"

    This method now accepts a mapping between port ids and resource
    providers as per I220fa02ee916728e241503084b14984bab4b0c3b.

    We'll need to figure how exactly should this dict look like.
    Meanwhile, we'll just pass "None", which Nova seems to accept
    for backwards compatibility reasons.

    This is a temporary workaround meant to unblock the gate. It will
    have to be properly handled by the time we release Ussuri, otherwise
    we won't be able to support port QoS.

    Change-Id: I878eab9615a76edab0f8ae5bb0d16652baae473a
    Partial-Bug: #1845480
    (cherry picked from commit 40bd35fcc2d9aecba490a88230f9e7302e6d59c1)

tags: added: in-stable-train
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers