Incorrect snapshot image format

[Lucian Petrut]

When taking instance snapshots, the image format is always set to "vhd", but it may as well be vhdx. This happens because of legacy reasons, as Glance used to reject vhdx images.

Cinder started to validate the image formats a few releases ago for security reasons, so it will reject creating volumes from Glance images that have incorrect image formats.

The Nova Hyper-V driver will have to set the right image format when taking snapshots.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/620907
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=a9a82b2e9bdf0549cdbc2b8ad1f6d81e5ca63de3
Submitter: Zuul
Branch: master

commit a9a82b2e9bdf0549cdbc2b8ad1f6d81e5ca63de3
Author: Lucian Petrut <email address hidden>
Date: Thu Nov 29 13:48:56 2018 +0200

    Report the correct image format to glance when snapshotting

    When taking instance snapshots, the image format is always set to
    "vhd", but it may as well be vhdx. This happens because of legacy
    reasons, as Glance used to reject vhdx images.

    Cinder started to validate the image formats a few releases ago for
    security reasons, so it will reject creating volumes from Glance
    images that have incorrect image formats.

    This change ensures that we'll set the right image format when taking
    snapshots.

    Closes-Bug: #1805442

    Change-Id: Ie151ed15bc806e0c16a363734d0c078fe358b899

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/compute-hyperv 9.0.0.0rc1 release candidate.