Instance snapshot/destroy failures
Bug #1748394 reported by
Lucian Petrut
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| compute-hyperv |
Fix Released
|
Undecided
|
Lucian Petrut | ||
Bug Description
At some point, we've removed the instance snapshot lock, allowing destroy requests to proceed immediately. We assumed that this should be fine as long as we're stopping pending WMI jobs.
The issue is that the snapshot operation is still not fully preemptive. VHD related operations (e.g. copy, merge, upload to glance) are not preemptive at the moment, for which reason destroy requests will fail due to file locks.
| Changed in compute-hyperv: | |
| assignee: | nobody → Lucian Petrut (petrutlucian94) |
| description: | updated |
| Changed in compute-hyperv: | |
| status: | New → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to compute-hyperv (master) | #1 |
| Changed in compute-hyperv: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 95e979d90722293
Author: Lucian Petrut <email address hidden>
Date: Fri Feb 9 09:39:10 2018 +0200
Lock snapshot/destroy operations
At some point, we've removed the instance snapshot lock, allowing
destroy requests to proceed immediately. We assumed that this
should be fine as long as we're stopping pending WMI jobs.
The issue is that the snapshot operation is still not fully
preemptive. VHD related operations (e.g. copy, merge, upload to
glance) are not preemptive at the moment, for which reason
destroy requests will fail due to file locks.
Unless the new 'force_
(disabled by default), we're locking the destroy/snapshot operations.
This partially reverts commit
e4208017feb
Closes-Bug: #1748394
Change-Id: I3119c5bc5a714b