Incomplete instance console log

[Lucian Petrut]

Hyper-V exposes instance serial console ports through named pipes. We're consuming those named pipes, logging the output to a file, retrieving the content when the console output is requested.

The issue is that the log file used by os-win never gets flushed (unless closed). For this reason, we're returning incomplete output.

This can easily be solved by flushing the log file before attempting to read its content.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/531421

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/531426

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531421
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=1b99d30fa2dd83524e87dfc71a8333acb91b2742
Submitter: Zuul
Branch: master

commit 1b99d30fa2dd83524e87dfc71a8333acb91b2742
Author: Lucian Petrut <email address hidden>
Date: Fri Jan 5 17:07:31 2018 +0200

    [Trivial] Allow flushing named pipe log handles

    The named pipe handler provided by os-win is used by Nova when
    consuming instance serial ports. For convenience, it allows logging
    the named pipe output to a file (useful for storing the serial
    console output).

    The issue is that the log file never gets flushed, thus Nova returns
    incomplete results. This change adds a method that may be used for
    flushing the log file.

    Change-Id: I4b5eb7579ac0c92e9c3630539b0c4d76f5b98c6d
    Closes-Bug: #1741494

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/540358

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/540358
Committed: https://git.openstack.org/cgit/openstack/os-win/commit/?id=f1a917598b519660fe4754b82dada3439832733b
Submitter: Zuul
Branch: stable/queens

commit f1a917598b519660fe4754b82dada3439832733b
Author: Lucian Petrut <email address hidden>
Date: Fri Jan 5 17:07:31 2018 +0200

    [Trivial] Allow flushing named pipe log handles

    The named pipe handler provided by os-win is used by Nova when
    consuming instance serial ports. For convenience, it allows logging
    the named pipe output to a file (useful for storing the serial
    console output).

    The issue is that the log file never gets flushed, thus Nova returns
    incomplete results. This change adds a method that may be used for
    flushing the log file.

    Change-Id: I4b5eb7579ac0c92e9c3630539b0c4d76f5b98c6d
    Closes-Bug: #1741494
    (cherry picked from commit 1b99d30fa2dd83524e87dfc71a8333acb91b2742)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-win 3.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/os-win 4.0.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531426
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=eb2c7b20a3e1328c1f3f5569bb5956a8ec230e8b
Submitter: Zuul
Branch: master

commit eb2c7b20a3e1328c1f3f5569bb5956a8ec230e8b
Author: Lucian Petrut <email address hidden>
Date: Fri Jan 5 18:28:02 2018 +0200

    Flush console log file before retrieving content

    Hyper-V exposes instance serial console ports through named pipes.
    We're consuming those named pipes, logging the output to a file,
    retrieving the content when the console output is requested.

    The issue is that the log file used by os-win never gets flushed
    (unless closed). For this reason, we're returning incomplete output.

    This change ensures that we're flushing the log file before attempting
    to read its content.

    Closes-Bug: #1741494

    Change-Id: Ic558b16b317e0b1478cc259327d1336f7589afe3
    Depends-On: I4b5eb7579ac0c92e9c3630539b0c4d76f5b98c6d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/552516

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552516
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=4af4d6c4e24f78241cd41ceea741a25de6a8da7f
Submitter: Zuul
Branch: stable/queens

commit 4af4d6c4e24f78241cd41ceea741a25de6a8da7f
Author: Lucian Petrut <email address hidden>
Date: Fri Jan 5 18:28:02 2018 +0200

    Flush console log file before retrieving content

    Hyper-V exposes instance serial console ports through named pipes.
    We're consuming those named pipes, logging the output to a file,
    retrieving the content when the console output is requested.

    The issue is that the log file used by os-win never gets flushed
    (unless closed). For this reason, we're returning incomplete output.

    This change ensures that we're flushing the log file before attempting
    to read its content.

    Closes-Bug: #1741494

    Change-Id: Ic558b16b317e0b1478cc259327d1336f7589afe3
    Depends-On: I4b5eb7579ac0c92e9c3630539b0c4d76f5b98c6d
    (cherry picked from commit eb2c7b20a3e1328c1f3f5569bb5956a8ec230e8b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/compute-hyperv 9.0.0.0rc1 release candidate.