hyperv: Driver does not report disk_available_least

[Claudiu Belu]

Description
===========

The Hyper-V driver does not report the disk_available_least field. Reporting the mentioned field can help mitigate the scheduling issue regarding hosts using the same shared storage.

Steps to reproduce
==================

Have a compute node having X GB total storage (reported as local_gb), out of which, just 1 GB is actually free (unreported). The compute node also reports local_gb_used, which is the sum of the allocated nova instances' flavor disk sizes. (local_gb > local_gb_used).

Try to spawn an instance with a flavor's disk higher than 1.or disk size of 2 GB on the host.

Expected result
===============

Instance should be in ERROR state, it shouldn't be able to schedule to the compute node.

Actual result
=============

The instance is active.

Environment
===========

OpenStack Pike.
Hyper-V 2012 R2 compute node.

Logs & Configs
==============

[1] compute node's resource view VS. actual reported resource view: http://paste.openstack.org/show/621318/
[2] compute node's resources (nova hypervisor-show), spawning an instance: http://paste.openstack.org/show/621319/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/504904

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/504905
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=6479f5539d5dc9e60467abc6bafdc6915320ee13
Submitter: Jenkins
Branch: master

commit 6479f5539d5dc9e60467abc6bafdc6915320ee13
Author: Claudiu Belu <email address hidden>
Date: Mon Sep 18 13:19:59 2017 +0300

    hyperv: report disk_available_least field

    Reporting the disk_available_least field can help in making sure
    the scheduler doesn't pick a host that cannot fit a specific flavor's
    disk.

    The reported local_gb_used is calculated based on the instances spawned
    by nova on a certain compute node, and might not reflect the actual
    reality, especially on shared storage scenarios.

    Change-Id: I20992acef119f11f6584094438043a760fc4a287
    Closes-Bug: #1717892

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/505248

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/505248
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=47c6e678d2906658bc51e9a4089a89897ed8e003
Submitter: Jenkins
Branch: stable/pike

commit 47c6e678d2906658bc51e9a4089a89897ed8e003
Author: Claudiu Belu <email address hidden>
Date: Mon Sep 18 13:19:59 2017 +0300

    hyperv: report disk_available_least field

    Reporting the disk_available_least field can help in making sure
    the scheduler doesn't pick a host that cannot fit a specific flavor's
    disk.

    The reported local_gb_used is calculated based on the instances spawned
    by nova on a certain compute node, and might not reflect the actual
    reality, especially on shared storage scenarios.

    Change-Id: I20992acef119f11f6584094438043a760fc4a287
    Closes-Bug: #1717892
    (cherry picked from commit 6479f5539d5dc9e60467abc6bafdc6915320ee13)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/504904
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=21bb17499f83ec67aaadd8affb6d2899e567d151
Submitter: Zuul
Branch: master

commit 21bb17499f83ec67aaadd8affb6d2899e567d151
Author: Claudiu Belu <email address hidden>
Date: Mon Sep 18 13:14:06 2017 +0300

    hyperv: report disk_available_least field

    Reporting the disk_available_least field can help in making sure
    the scheduler doesn't pick a host that cannot fit a specific flavor's
    disk.

    The reported local_gb_used is calculated based on the instances spawned
    by nova on a certain compute node, and might not reflect the actual
    reality, especially on shared storage scenarios.

    Change-Id: I20992acef119f11f6584094438043a760fc4a287
    Closes-Bug: #1717892

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.0.0b2 development milestone.