Hyper-V: Instance ports not bound after resize

[Lucian Petrut]

When using OVS, the Hyper-V driver creates the OVS ports only after the instance is powered on (due to a Hyper-V limitation).

The issue is that in case of cold migrations/resize, this step is currently skipped, as the driver doesn't pass the network info object when powering on the instance:
https://github.com/openstack/nova/blob/07b6580a1648a860eefb5a949cb443c2a335a89a/nova/virt/hyperv/migrationops.py#L300-L301

Simply passing that object will fix the issue.

[Matt Riedemann (mriedem)]

I see that doesn't pass the block_device_info into the power_on method either, is that needed as well?

[Matt Riedemann (mriedem)]

I guess we don't test ssh after a resize in Tempest...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/422314

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/422314
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=568a682e5efa6e4fd49b69e02cbd80f1d8a96c63
Submitter: Jenkins
Branch: master

commit 568a682e5efa6e4fd49b69e02cbd80f1d8a96c63
Author: Matt Riedemann <email address hidden>
Date: Wed Jan 18 18:47:24 2017 -0500

    hyperv: make sure to plug OVS VIFs after resize/migrate

    Since the network_info wasn't getting passed to vmops.power_on
    after a resize/cold migrate confirmation, the OVS VIFs weren't
    getting plugged.

    Change-Id: Ia9b7dc11cd74ba896a7254c16a95b7a834a28475
    Closes-Bug: #1657424

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/430398

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/434897
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=5eb0db9b369dbcf594e0dd66fcebf12c69699417
Submitter: Jenkins
Branch: master

commit 5eb0db9b369dbcf594e0dd66fcebf12c69699417
Author: Claudiu Belu <email address hidden>
Date: Thu Feb 16 15:11:11 2017 +0200

    hyperv: make sure to plug OVS VIFs after resize/migrate

    Since the network_info wasn't getting passed to vmops.power_on
    after a resize/cold migrate confirmation, the OVS VIFs weren't
    getting plugged.

    (cherry-picked from commit 568a682e5efa6e4fd49b69e02cbd80f1d8a96c63)

    Change-Id: I9097debeb68cb25dec27e7b3e979cf51d951c250
    Closes-Bug: #1657424

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/430398
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=14440efb229028a5d3d4e4a1bc0c38c9a2bb5ef0
Submitter: Jenkins
Branch: stable/ocata

commit 14440efb229028a5d3d4e4a1bc0c38c9a2bb5ef0
Author: Matt Riedemann <email address hidden>
Date: Wed Jan 18 18:47:24 2017 -0500

    hyperv: make sure to plug OVS VIFs after resize/migrate

    Since the network_info wasn't getting passed to vmops.power_on
    after a resize/cold migrate confirmation, the OVS VIFs weren't
    getting plugged.

    Change-Id: Ia9b7dc11cd74ba896a7254c16a95b7a834a28475
    Closes-Bug: #1657424
    (cherry picked from commit 568a682e5efa6e4fd49b69e02cbd80f1d8a96c63)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.1 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/453785

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/453785
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=701f37a9fa41e6c0ff6fd3a283a43cdf21d705cc
Submitter: Jenkins
Branch: stable/newton

commit 701f37a9fa41e6c0ff6fd3a283a43cdf21d705cc
Author: Claudiu Belu <email address hidden>
Date: Thu Feb 16 15:11:11 2017 +0200

    hyperv: make sure to plug OVS VIFs after resize/migrate

    Since the network_info wasn't getting passed to vmops.power_on
    after a resize/cold migrate confirmation, the OVS VIFs weren't
    getting plugged.

    NOTE(claudiub): the way migrations work changed in Ocata, which is
    the reason of the conflict.

    (cherry-picked from commit 568a682e5efa6e4fd49b69e02cbd80f1d8a96c63)

    (cherry picked from commit 5eb0db9b369dbcf594e0dd66fcebf12c69699417)

    Conflicts:
     hyperv/nova/migrationops.py
     hyperv/tests/unit/test_migrationops.py

    Closes-Bug: #1657424

    Change-Id: I9097debeb68cb25dec27e7b3e979cf51d951c250