compute-hyperv

Hyper-V: vhd config drive images are not migrated

Bug #1619602 reported by Lucian Petrut on 2016-09-02

This bug affects 2 people

	Status	Importance	Assigned to
OpenStack Compute (nova)	Fix Released	High	Lucian Petrut
Newton	Fix Committed	Medium	Matt Riedemann
compute-hyperv	Fix Released	Undecided	Unassigned

Bug Description

During cold migration, vhd config drive images are not copied over, on the wrong assumption that the instance is already configured and does not need the config drive.

There is an explicit check at the following location:
https://github.com/openstack/nova/blob/8f35bb321d26bd7d296c57f4188ec12fcde897c3/nova/virt/hyperv/migrationops.py#L75-L76

For this reason, migrating instances using vhd config drives will fail, as there is a check ensuring that the config drive is present, if required:
https://github.com/openstack/nova/blob/8f35bb321d26bd7d296c57f4188ec12fcde897c3/nova/virt/hyperv/migrationops.py#L153-L163

The Hyper-V driver should not skip moving the config drive image.

See original description

Tags:

Lucian Petrut (petrutlucian94) on 2016-09-02

affects:

os-win → nova

Lucian Petrut (petrutlucian94) on 2016-09-02

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-16: Fix merged to nova (master)

Reviewed: https://review.openstack.org/364829
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2dd231cff199bd75bcd3d1031a9ff0a1a82ec1cb
Submitter: Jenkins
Branch: master

commit 2dd231cff199bd75bcd3d1031a9ff0a1a82ec1cb
Author: Lucian Petrut <email address hidden>
Date: Fri Sep 2 13:39:29 2016 +0300

HyperV: ensure config drives are copied as well during resizes

    During cold migration, vhd config drive images are not copied
    over, on the wrong assumption that the instance is already
    configured and does not need the config drive.

    For this reason, migrating instances using vhd config drives
    will fail, as there is a check ensuring that the config drive
    is present, if required.

This change addresses the issue, removing the check that was
preventing the config drive from being copied.

Change-Id: I8cd42bed4515f4f75c92e595c4d8b847b16058dd
Closes-Bug: #1619602

Changed in nova:
status:	New → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-29: Fix proposed to nova (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/379817

Matt Riedemann (mriedem) on 2016-09-29

Changed in nova:
importance:	Undecided → High
assignee:	nobody → Lucian Petrut (petrutlucian94)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-17: Fix merged to nova (stable/newton)

Reviewed: https://review.openstack.org/379817
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d39f4c8e901b6247bd043d17b324e17833235ddc
Submitter: Jenkins
Branch: stable/newton

commit d39f4c8e901b6247bd043d17b324e17833235ddc
Author: Lucian Petrut <email address hidden>
Date: Fri Sep 2 13:39:29 2016 +0300

HyperV: ensure config drives are copied as well during resizes

    During cold migration, vhd config drive images are not copied
    over, on the wrong assumption that the instance is already
    configured and does not need the config drive.

    For this reason, migrating instances using vhd config drives
    will fail, as there is a check ensuring that the config drive
    is present, if required.

This change addresses the issue, removing the check that was
preventing the config drive from being copied.

    Change-Id: I8cd42bed4515f4f75c92e595c4d8b847b16058dd
    Closes-Bug: #1619602
    (cherry picked from commit 2dd231cff199bd75bcd3d1031a9ff0a1a82ec1cb)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-18: Fix merged to compute-hyperv (master)

Reviewed: https://review.openstack.org/387361
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=93a4cb6207ed35b7b5325b5b03bff5126677695f
Submitter: Jenkins
Branch: master

commit 93a4cb6207ed35b7b5325b5b03bff5126677695f
Author: Lucian Petrut <email address hidden>
Date: Mon Oct 17 14:20:12 2016 +0300

HyperV: ensure config drives are copied as well during resizes

    During cold migration, vhd config drive images are not copied
    over, on the wrong assumption that the instance is already
    configured and does not need the config drive.

    For this reason, migrating instances using vhd config drives
    will fail, as there is a check ensuring that the config drive
    is present, if required.

This change addresses the issue, removing the check that was
preventing the config drive from being copied.

(cherry-picked from commit 2dd231cff199bd75bcd3d1031a9ff0a1a82ec1cb)

Change-Id: I8cd42bed4515f4f75c92e595c4d8b847b16058dd
Closes-Bug: #1619602

Changed in compute-hyperv:
status:	New → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-07: Fix included in openstack/nova 14.0.2

This issue was fixed in the openstack/nova 14.0.2 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-17: Fix included in openstack/nova 15.0.0.0b1

This issue was fixed in the openstack/nova 15.0.0.0b1 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-07: Fix included in openstack/nova 14.0.2

This issue was fixed in the openstack/nova 14.0.2 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-04-05: Fix proposed to compute-hyperv (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/453784

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-04-25: Fix merged to compute-hyperv (stable/newton)

#10

Reviewed: https://review.openstack.org/453784
Committed: https://git.openstack.org/cgit/openstack/compute-hyperv/commit/?id=1e2cc6ff213bc3ffafd57bfc162b67acae2c0ecc
Submitter: Jenkins
Branch: stable/newton

commit 1e2cc6ff213bc3ffafd57bfc162b67acae2c0ecc
Author: Lucian Petrut <email address hidden>
Date: Mon Oct 17 14:20:12 2016 +0300

HyperV: ensure config drives are copied as well during resizes

    During cold migration, vhd config drive images are not copied
    over, on the wrong assumption that the instance is already
    configured and does not need the config drive.

    For this reason, migrating instances using vhd config drives
    will fail, as there is a check ensuring that the config drive
    is present, if required.

This change addresses the issue, removing the check that was
preventing the config drive from being copied.

(cherry-picked from commit 2dd231cff199bd75bcd3d1031a9ff0a1a82ec1cb)

Change-Id: I8cd42bed4515f4f75c92e595c4d8b847b16058dd
Closes-Bug: #1619602