Coverity CHECKED_RETURN - CID 12403 - src/option/tests/option.cpp - in function: CompOption_AssignDefaultActionValueToUnsetTypeClearsOldStateKeepsInfo_Test::TestBody() - Calling function "CompOption::set(CompOption::Value &)" without checking return value (as is done elsewhere 1171 out of 1219 times). No check of the return value of "option.set(value)".

Bug #1101528 reported by Product Strategy Coverity Bug Uploader
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
New
Medium
Unassigned
0.9.9
New
Medium
Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 12403
Checker: CHECKED_RETURN
Category: No category available
CWE definition: http://cwe.mitre.org/data/definitions/252.html
File: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/option/tests/option.cpp
Function: CompOption_AssignDefaultActionValueToUnsetTypeClearsOldStateKeepsInfo_Test::TestBody()
Code snippet:
225 ASSERT_EQ (value.action ().state (), CompAction::StateInitKey);
226
227 /* Actually set the action value, this will
228 * overwrite the internal value */
CID 12403 - CHECKED_RETURN
Calling function "CompOption::set(CompOption::Value &)" without checking return value (as is done elsewhere 1171 out of 1219 times).
No check of the return value of "option.set(value)".
229 option.set (value);
230
231 /* We don't care about the old action's state, so get
232 * rid of it */
233 ASSERT_EQ (option.value ().action ().state (), 0);
234

Revision history for this message
Product Strategy Coverity Bug Uploader (coverity-uploader) wrote : compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/option/tests/option.cpp

Source file with Coverity annotations.

Changed in compiz:
importance: Undecided → Medium
MC Return (mc-return)
Changed in compiz:
milestone: none → 0.9.10.0
summary: - Coverity CHECKED_RETURN - CID 12403
+ Coverity CHECKED_RETURN - CID 12403 - src/option/tests/option.cpp - in
+ function:
+ CompOption_AssignDefaultActionValueToUnsetTypeClearsOldStateKeepsInfo_Test::TestBody()
+ - Calling function "CompOption::set(CompOption::Value &)" without
+ checking return value (as is done elsewhere 1171 out of 1219 times). No
+ check of the return value of "option.set(value)".
Changed in compiz:
milestone: 0.9.10.0 → 0.9.10.2
MC Return (mc-return)
Changed in compiz:
milestone: 0.9.10.2 → 0.9.11.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.