Cleanup code - Code that belongs to PrivateScreen is in CompScreenImpl (and others)

Bug #931522 reported by Alan Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Triaged
Low
Unassigned

Bug Description

CompScreenImpl has too much "priv->[dataMember]".

Actually, PrivateScreen could probably be a data member of CompScreenImpl (and CompScreenImpl moved out of the core header).

Additionally, the following friends in CompScreen are there because they own code that is in the wrong place:

    friend class CompWindow; // TODO get rid of friends
    friend class PrivateWindow; // TODO get rid of friends
    friend class ModifierHandler; // TODO get rid of friends
    friend class CompManager; // TODO get rid of friends

Stephen M. Webb (bregma)
no longer affects: compiz-core
Changed in compiz:
importance: Undecided → Low
status: New → Triaged
Stephen M. Webb (bregma)
tags: added: refactor-for-testability
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.