Window management - When a semi-maximised a window is maximised and then restored, the window position jumps and window size changes so the the window title bar is sometimes hidden underneath the top bar

[John Lea]

Note: reverting bug to triarged because the fix is not complete. When tested the correct behavour of "the window should return to exactly the same state it had at the beginning of step 1." is not fulfilled.

-----------------------------------

Window management - When a Semi-maximising a window is maximised by clicking on the window decorations and then returned to the semi-maximised state, the window position jumps so the the window title bar is hidden underneath the top bar.

One way reproduce the bug:
1. Take a restored window
2. Semi-maximise the window
3. Press CTRL + SUPER + UP ARROW to maximise the window
4. Click on the 'restore' window decoration to return the window to the restored state state.

What currently incorrectly happens:
- After performing step 3, the window returns to a weird state where it is restored, but in the size and shape of a semi-maximised window, and the position is also offset from what would be expected from a semi-maximised window. This is especially problematic because in some cases the window is positioned so that all of the window title bar is underneath the top bar, making it impossible for a user to move the window without knowing a keyboard shortcut.

See the attached screencast "window_positioning_issue.ogv" to see the bug in action. (In the screencast this bug is reproduced using the window decorations instead of the Alt+F10 shortcut, which won't be possible after bug https://bugs.launchpad.net/ayatana-design/+bug/796594 is fixed)

Desired behavour:
- On pressing the 'restore' window decoration in step 4 of the bug reproduction instructions, the window should return to exactly the same state it had at the beginning of step 1.
- When fixing this bug, also review and look at fixing bug https://bugs.launchpad.net/ayatana-design/+bug/796594 as these issues are related

-------------------------------------------

Another way to reproduce the bug:
1. Semi-maximise the Thunderbird main window
2. Press the 'restore' window decoration (button on the far right of the 3 button cluster)

What currently incorrectly happens:
- The window jumps up so that the window title bar in underneath the top bar

What should happen
- The window should return to it's previous 'restored' state.

[Marco Trevisan (Treviño) (3v1n0)]

I can't reproduce this anymore with newest compiz, please check it again.

[RichardHDF (richardhdf)]

When one semi-maximises a window by dragging its title bar to the right and then tries to restore it by dragging its title bar away from the top, the window also jumps quite far away from the cursor while still holding in the click. This behaviour is quite awkward. Was this also fixed in this commit?

[Sam Spilsbury (smspillaz)]

This is a race condition and won't be fixed until Q. See lp:~smspillaz/compiz-core/compiz-core.work_923683

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[WhyNotHugo (whynothugo)]

Can you just hold alt and drag the window down in order to see the titlebar again? Or is alt+dragging no longer a default?

[John Lea (johnlea)]

@hugo.osvaldobarrera; of course you can, but you need to know about ALT+dragging in order to do this! This is a major usability showstopper for new users.

[Daniel van Vugt (vanvugt)]

Fix committed into lp:compiz-core at revision 3110.

[Daniel van Vugt (vanvugt)]

I'm not sure this should be assigned to unity. Looks like just a compiz bug (now fixed).

[Omer Akram (om26er)]

Would have been nice to see this as SRU but the change looks non trivial for an SRU. Also wondering should unity be removed as affects now?

[Omer Akram (om26er)]

(upstream one)

[Omer Akram (om26er)]

Now in Quantal we have bzr 3249 should we close this bug as fixed now?

[Daniel van Vugt (vanvugt)]

This bug was fixed in the package compiz - 1:0.9.8.0-0ubuntu1

---------------
compiz (1:0.9.8.0-0ubuntu1) quantal-proposed; urgency=low

  * debian/control, debian/rules:
    - enable gles on armel and armhf
    - use dh-translations rather than custom code

  [ Sam Spilsbury ]
  * Enable OpenGL ES building
    - Refresh debian/patches/workaround_broken_drivers.patch
    - Remove non-ported plugins from compiz-plugins
    - Add FindOpenGLES2.cmake to compiz-dev

  [ Timo Jyrinki ]
  * New upstream release.
    - Code to make compiz work on GLES. This includes several changes
      to the compiz API. (LP: #201342) (LP: #901097) (LP: #1004251)
      (LP: #1037710)
    - Draft first 0.9.8.0 NEWS and bump VERSION
  * debian/patches/compiz-package-gles2.patch:
    - Remove, obsoleted by the upstream GLES work
  * Disable plugins that don't work on pure GLES on armhf/armel:
    - bench, firepaint, mblur, showmouse, splash, showrepaint, td, widget
 -- Sebastien Bacher <email address hidden> Fri, 31 Aug 2012 22:59:50 +0200

[John Lea (johnlea)]

Reverting bug to triarged as issue is not completly fixed, see note added to top of description.

[MC Return (mc-return)]

AFAIK this bug has already been fixed in trunk.

[MC Return (mc-return)]

Here: https://code.launchpad.net/~mc-return/compiz/compiz.merge-grid-small-cleanup/+merge/161330

[Brandon Schaefer (brandontschaefer)]

@ MC

Part of it was, now that im looking at trunk (but im also having problems running unity/compiz atm).

But the Semi max -> Full Max -> Restore is what this bug is about. As when you doing a Full max it doesn't touch the grid plugin...soo im marking this back as in progress...

[MC Return (mc-return)]

Well, I cannot reproduce this particular bug...

But bug #1115341 is still open - maybe you want to look into that one ?
(I had no time to fix it yet)

[Brandon Schaefer (brandontschaefer)]

Well let me get trunk compiz running and confirm its fixed ... as this could be only a problem in the compiz/raring branch

[MC Return (mc-return)]

Sure...

[Brandon Schaefer (brandontschaefer)]

Im still getting this very close to trunk (for some reason trunk compiz seems to hate me atm...). Soo im going to propose a branch later today to fix this. :)

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:compiz at revision 3762, scheduled for release in compiz, milestone 0.9.10.0

[Launchpad Janitor (janitor)]

This bug was fixed in the package compiz - 1:0.9.10+13.10.20130822-0ubuntu1

---------------
compiz (1:0.9.10+13.10.20130822-0ubuntu1) saucy; urgency=low

  [ Sam Spilsbury ]
  * Bump version to 0.9.10

  [ Łukasz 'sil2100' Zemczak ]
  * Remove debian/patches/unity_support_test.patch:
    - Running the support test from compiz has bad side effects, from now
      on we run it from Xsession.d
  * Automatic snapshot from revision 3644

  [ Iven Hsu ]
  * Opacify: Only dim the windows above the active window.(LP:
    #1189374). (LP: #1189374)
  * KWD: Fix compile errors with KDE 4.11. The KWin developers made
    kdecorationbridge.h private. See:
    http://lists.freedesktop.org/archives/compiz/2013-March/003479.html
    (LP: #1193792). (LP: #1193792)

  [ Nikolay Martynov ]
  * When static switcher is enabled and has an option to show
    application icon turned on the icons are expected to be ~1/3 of a
    thumbnail (48px). Instead they are displayed in 512px size and
    completely cover everything. This change addresses this issue. See
    LP #1173914. (LP: #1173914, #1186426)

  [ BryanFRitt ]
  * Fixed the non-working Annotate 'Clear' Button. Moved this option's
    CCSM position upwards to keep the button shortcuts together. (LP:
    #1202907). (LP: #1202907)

  [ Mehrdad Afshari ]
  * Added "move window to previous monitor" feature to compiz Put
    plugin. (LP: #1178581)

  [ Hu Kang ]
  * gtk-window-decorator: destroy action menu when any of the (close,
    min, max) buttons on the title bar is pressed. (LP: #1101648)
  * Remove redundant src/logmessage/include/core/logmessage.h (LP:
    #1067246). (LP: #1067246)

  [ Steve Langasek ]
  * Fix for bug #763148 (with added test cases): when the desktop is
    resized, windows should stay on their original workspace. (LP:
    #763148)

  [ Brandon Schaefer ]
  * Unrevert 3728, fix failing tests. Change the behaviour of
    undecorating windows. Previously when a window was undecorated, we
    would shift it back to an appropriate position according to its
    gravity member. That behaviour was problematic because in the
    StaticGravity case the window has to just stay in the same place.
    But then if you had a window with StaticGravity which then did get a
    decoration and later removed it, it would be placed as though it was
    decorated and appear to be in the wrong place. The correct behaviour
    is to place all windows as though they have decorations, and then
    when decorations are removed, to move the window back to the corner
    as indicated in its gravity and then expand its size to cover the
    obscured regions no longer hidden because the decorations went away.
    (LP: #1165343).   1. Completely remove decorOffsetMove and other
    related code from      decor.cpp. Put the logic to handle the
    window->input () - window->border ()      placement offset inside of
    setWindowFrameExtents instead. Now the window      will always be
    offset from its original non-decorated position to the new
         decorated position, rather than having to guess between
    decoration sizes.   2. Make saveGeometry and restoreGeometry work
    relative to window->border ()      a...