compiz-decorator shell script needlessly keeps running after running decorator process

[Tristan Wibberley]

Binary package hint: compiz-core

The end of compiz-decorator looks like this:

if [ -n "$DECORATOR" ]; then
    verbose "Starting ${DECORATOR}\n"
    ${COMPIZ_BIN_PATH}$DECORATOR "$@"
else
    verbose "Found no decorator to start\n"
    exec $FALLBACKWM $FALLBACKWM_OPTIONS
fi

I think it could equally well look like this:

if [ -n "$DECORATOR" ]; then
    verbose "Starting ${DECORATOR}\n"
    exec ${COMPIZ_BIN_PATH}$DECORATOR "$@"
else
    verbose "Found no decorator to start\n"
    exec $FALLBACKWM $FALLBACKWM_OPTIONS
fi

and the shell process will be replaced with the compiz process as for the fallback branch instead of continuing to run.

[Robert Ancell (robert-ancell)]

Reported upstream:
http://bugs.opencompositing.org/show_bug.cgi?id=1149

[Michael Vogt (mvo)]

Thanks!

I merged the decorator patch. The other change:

-${COMPIZ_BIN_PATH}${COMPIZ_NAME} $COMPIZ_OPTIONS "$@" $COMPIZ_PLUGINS || exec $FALLBACKWM $FALLBACKWM_OPTIONS
+exec ${COMPIZ_BIN_PATH}${COMPIZ_NAME} $COMPIZ_OPTIONS "$@" $COMPIZ_PLUGINS || exec $FALLBACKWM $FALLBACKWM_OPTIONS

is left out because one of the nice properties of this approach is that if compiz crashes or can not be run, the fallback window manager (usually metacity) gets run.

[Launchpad Janitor (janitor)]

This bug was fixed in the package compiz - 1:0.8.2-0ubuntu13

---------------
compiz (1:0.8.2-0ubuntu13) karmic; urgency=low

  [ Robert Ancell ]
  * debian/compiz-decorator:
    - Exec binaries from scripts so no script processes waste memory
      (LP: #305740)

 -- Michael Vogt <email address hidden> Mon, 15 Jun 2009 11:53:19 +0200