gtk-window-decorator does not maximize windows when the titlebar is double-clicked

Bug #1778565 reported by Stephen Karanja on 2018-06-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Undecided
Unassigned

Bug Description

Hi Guys,

When /usr/bin/gtk-window-decorator is configured as Compiz's window decorator, windows don't maximize when double-clicked, even though this is the configured behavior for the titlebar double-click action.

The window maximization is prevented by the low double-click timeout hard-coded into Compiz (250 milliseconds). I bet it would be tough for most folks to register two clicks within 250 ms.

See line 110 in gtk/window-decorator/gtk-window-decorator.c.

    gint double_click_timeout = 250;

I'm wondering whether this low timeout was chosen arbitrarily or whether there's a reason for it.

I've attached two patches, either of which solves this issue for me:

a) gtk-window-decorator.c.patch - This patch simply increases the above timeout value to 550 milliseconds; a more pragmatic value for me. For others? I can't say.

b) events.c.patch - This patch changes title_event() in gtk/window-decorator/events.c to read "gtk-double-click-time" and "gtk-double-click-distance" from GtkSettings, as set by the user. I borrowed this from Marco window manager's code.

I'd like to see this fixed using whichever way is most appropriate so that I (and probably others) can have window maximization upon double-clicking the titlebar.

Thanks.

Stephen Karanja (caw) wrote :
Stephen Karanja (caw) wrote :

I've attached the alternative patch for gtk/window-decorator/events.c.

Stephen Karanja (caw) on 2018-06-25
description: updated
Khurshid Alam (khurshid-alam) wrote :

The value is not a arbitrary value. It is well thought out. For me doble click registers every time. May be some issue with input devices ?

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers