winrules arbitrarily limits window sizes to 4096 pixels

Bug #1431923 reported by K. Lange
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Fix Released
Medium
Unassigned
0.9.11
Triaged
Medium
Unassigned
compiz (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The configuration schema for the "winrules" plugin sets an arbitrary maximum width and height for window sizes to 4096 pixels. This limitation was introduced in git commit 3bf4bb10c34284d0a6dc1fd8e51c5991074d3c06 (circa 2010). With standardized display resolutions that exceed 4096 pixels, and the prevalence of multiple-display setups, this limit makes a lot less sense than it did in 2010. It's hard to pick a good value for a maximum here, as anything reasonable has the chance of very quickly becoming restrictive. We could just as well remove the maximum altogether and CCSM would be perfectly happy. I've chosen to use another arbitrary, but notably higher, limit in the attached patch.

This issue was discovered while trying to use winrules to work around a window size bug in a game (Cities: Skylines) which was thoroughly convinced its window was the full 5760 pixels of my display setup, but had only managed to get a 1920x1080 window. Normally I would consider this sort of thing to be too frivolous to report, but I used to be much more active in Compiz development several years ago and was interested in seeing what the community looked like these days.

Related branches

Revision history for this message
K. Lange (k-lange) wrote :
Revision history for this message
K. Lange (k-lange) wrote :

As an aside, I believe Sam chose 4096 as it was an incredibly common maximum texture width/height in high-end GPUs at the time - we simply couldn't support wider windows.

Stephen M. Webb (bregma)
Changed in compiz:
importance: Undecided → Medium
milestone: none → 0.9.12.2
status: New → Triaged
Stephen M. Webb (bregma)
Changed in compiz:
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.12.1+15.04.20150330-0ubuntu1

---------------
compiz (1:0.9.12.1+15.04.20150330-0ubuntu1) vivid; urgency=medium

  [ Chris Townsend ]
  * Change default behavior of focus-follows-mouse where the desktop
    will get focus when the mouse is over it. Also add option to allow
    old behavior. (LP: #1427636)
  * Clear out the lastMask vars when using the mouse to resize. (LP:
    #1348254)

  [ Eleni Maria Stea ]
  * Minor optimisation fix: Replaced glLoadIdentity, glMultMatrixf with
    glLoadMatrixf to avoid the unnecessary matrix multiplication:
    identity * some projection matrix

  [ Kevin Lange ]
  * WinRules plugin: boost arbitrary window size limits to something
    more reasonable (LP: #1431923)

  [ Stephen M. Webb ]
  * animations plugin: fixed a potential null pointer dereference (LP:
    #1101573)
 -- CI Train Bot <email address hidden> Mon, 30 Mar 2015 15:58:21 +0000

Changed in compiz (Ubuntu):
status: New → Fix Released
Stephen M. Webb (bregma)
Changed in compiz:
status: In Progress → Fix Committed
Stephen M. Webb (bregma)
Changed in compiz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.