Vertical maximise widens windows

[CatKiller]

I'm using Compiz 1:0.9.10.2-1-experimental1+bzr3727-201305290236~quantal1.

Both when vertically maximising a window and when restoring it to its former size the width increases, I'd estimate by somewhere between 20 and 50 pixels.

The previous behaviour - that the width of a window remains constant when maximising vertically - was the correct one.

I'm not sure exactly when this bug started since it's not something I do ever so often.

Maximising horizontally appears to work correctly.

[MC Return (mc-return)]

Some magic numbers are still left ;)
Thanks 4 the report -> I'll investigate it...

[MC Return (mc-return)]

I am not able to reproduce that in trunk.

CatKiller, can you detail exact steps to reproduce the behaviour ?

There are multiple possible versions to semi-maximize a window vertically (grid+keyboard, grid+mouse, shortcut, button,...) and multiple versions of restoring it...

[CatKiller (catkiller)]

The way I'm triggering it is middle-click on the maximise button. Same for restoring. I'm not sure what's handling the action with that approach.

[Sam Spilsbury (smspillaz)]

CatKiller which decoration theme are you using?

(Also, that ppa is out of date).

[Sam Spilsbury (smspillaz)]

Confirmed on trunk here thought.

[Sam Spilsbury (smspillaz)]

BTW, windows are getting smaller on horizontal maximize it seems.

[Sam Spilsbury (smspillaz)]

I have a fix for both this and bug 1186723 , but ...

I'm not a huge fan of the way things are working at the moment. I think we really need a proper testsuite around this functionality before we land any more fixes. A lot of the behavior around maximization and decoration is very very tightly coupled and fixing one thing often breaks another.

I'll post the fixes up for a test-only review, but I think we should hold any further work here until the acceptance test suite is delivered. I'll make that a top priority.

[MC Return (mc-return)]

Here to trigger the widening, I need to restart Compiz -> then each window widens by 22 pixels...

[MC Return (mc-return)]

Isn't this fixed by now ?

[CatKiller (catkiller)]

Are you asking me? I don't know, I don't even run that branch any more. Sam was fixing it, and it appeared fixed before I stopped using that branch, but Sam said he had more work to do on the decoration code. I don't know how far he got with his test suite.

[Sam Spilsbury (smspillaz)]

Its done and merged upstream now. r3765

On Thu, Aug 8, 2013 at 5:32 AM, CatKiller <email address hidden>wrote:

> Are you asking me? I don't know, I don't even run that branch any more.
> Sam was fixing it, and it appeared fixed before I stopped using that
> branch, but Sam said he had more work to do on the decoration code. I
> don't know how far he got with his test suite.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1186560
>
> Title:
> Vertical maximise widens windows
>
> Status in Compiz:
> Incomplete
>
> Bug description:
> I'm using Compiz
> 1:0.9.10.2-1-experimental1+bzr3727-201305290236~quantal1.
>
> Both when vertically maximising a window and when restoring it to its
> former size the width increases, I'd estimate by somewhere between 20
> and 50 pixels.
>
> The previous behaviour - that the width of a window remains constant
> when maximising vertically - was the correct one.
>
> I'm not sure exactly when this bug started since it's not something I
> do ever so often.
>
> Maximising horizontally appears to work correctly.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/compiz/+bug/1186560/+subscriptions
>

--
Sam Spilsbury