xorg-gtest tests always fail when two test runs are run on the same machine in parallel
Bug #1178514 reported by
Sam Spilsbury
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Compiz |
Fix Released
|
High
|
Sam Spilsbury | ||
compiz (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
If two xorg-gtest tests are run at the same time in paralell, both will try and create a new server instance on :133 and the second one will fail. This is mainly because xorg_gest_main makes that assumption. For now we can just replace xorg_gtest_main with our own main () which does the right thing, namely incrementing the display number on failure.
The real fix is to run each test run in its own process space so that you can't have such conflicts, but that's a much more difficult task.
Related branches
lp:~compiz-team/compiz/compiz.fix_1178514
- Sam Spilsbury: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- MC Return: Approve
-
Diff: 234 lines (+161/-10)5 files modifiedplugins/decor/src/pixmap-requests/tests/integration/xorg-gtest/CMakeLists.txt (+1/-1)
tests/acceptance-tests/xorg-gtest/tests/CMakeLists.txt (+1/-1)
tests/system/xorg-gtest/tests/CMakeLists.txt (+1/-1)
tests/xorg-gtest/CMakeLists.txt (+4/-7)
tests/xorg-gtest/src/compiz_xorg_gtest_main.cpp (+154/-0)
summary: |
- xorg-gtest tests can fail when two test runs are run on the same machine - in parallel + xorg-gtest tests always fail when two test runs are run on the same + machine in parallel |
description: | updated |
Changed in compiz: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:compiz at revision None, scheduled for release in compiz, milestone 0.9.10.0