Move plugin: Snapback for semimaximized windows should be configurable (on/off)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Compiz |
Fix Released
|
Wishlist
|
MC Return | ||
compiz (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The SNAP_BACK code makes no sense and should probably be removed:
if (ms->optionGetS
{
if (w->state () & CompWindowState
abs (yRoot - workArea.y () - ms->snapOffY) >= SNAP_OFF &&
!
{
}
else if (w->state () & CompWindowState
abs (xRoot - workArea.x () - ms->snapOffX) >= SNAP_OFF &&
!s-
{
}
/* the part below is useless and should IMHO be removed */
else if (ms->origState & CompWindowState
abs (yRoot - workArea.y () - ms->snapBackY) < SNAP_BACK &&
!s-
{
w->maximize (ms->origState);
int wy = workArea.y () + (w->border ().top >> 1);
wy += w->sizeHints ().height_inc >> 1;
s-
return;
}
}
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Sam Spilsbury: Approve
- MC Return: Pending requested
-
Diff: 658 lines (+207/-181)3 files modifiedplugins/move/move.xml.in (+31/-10)
plugins/move/src/move.cpp (+169/-166)
plugins/move/src/move.h (+7/-5)
Changed in compiz: | |
assignee: | nobody → MC Return (mc-return) |
status: | New → In Progress |
Changed in compiz: | |
milestone: | none → 0.9.10.0 |
importance: | Undecided → Wishlist |
Changed in compiz: | |
status: | Fix Committed → Fix Released |
I fixed it instead.