Multiple minor code and style issues

Bug #1134251 reported by MC Return on 2013-02-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Low
MC Return
compiz (Ubuntu)
Undecided
Unassigned

Bug Description

cppcheck reports these valid issues:

[plugins/cubeaddon/src/cubeaddon.cpp:320] -> [plugins/cubeaddon/src/cubeaddon.cpp:322]: (performance) Variable 'rv' is reassigned a value before the old one has been used.

[compizconfig/libcompizconfig/src/compiz.cpp:731] -> [compizconfig/libcompizconfig/src/compiz.cpp:735]: (performance) Variable 'readonly' is reassigned a value before the old one has been used.

Other minor issues:

* Some guaruntee->guarantee typos in the code comments.

* Some copyright headers are still referring to the old .c files.

* Some copyright headers are not referring to the correct file names (mainly animation file headers).

Related branches

MC Return (mc-return) on 2013-02-27
Changed in compiz:
assignee: nobody → MC Return (mc-return)
status: New → In Progress
MC Return (mc-return) on 2013-02-27
description: updated
description: updated
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:compiz at revision None, scheduled for release in compiz, milestone 0.9.9.2

Changed in compiz:
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.9~daily13.03.01-0ubuntu1

---------------
compiz (1:0.9.9~daily13.03.01-0ubuntu1) raring; urgency=low

  [ MC Return ]
  * Multiple minor code and style issues (LP: #1134251)

  [ Automatic PS uploader ]
  * Automatic snapshot from revision 3629
 -- Automatic PS uploader <email address hidden> Fri, 01 Mar 2013 04:02:19 +0000

Changed in compiz (Ubuntu):
status: New → Fix Released
MC Return (mc-return) on 2013-06-15
Changed in compiz:
importance: Undecided → Low
Stephen M. Webb (bregma) on 2015-03-19
Changed in compiz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers