Showmouse plugin code: Needs cleanup
Bug #1105969 reported by
MC Return
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Compiz |
Fix Released
|
Undecided
|
MC Return | ||
| compiz (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
* One rVal (random value) is calculated without being used.
* nE (the number of emitters) is type-converted to unsigned int, which is unnecessary as nE can just get int values from 1 to 10 assigned anyway.
* nE is unnecessarily calculated using MIN (10, optionGetEmitters ()), which again is redundant protection (see above).
Related branches
lp:~mc-return/compiz/compiz.merge-fix1105969-showmouse-code-needs-cleanup
- Brandon Schaefer (community): Approve
- Sam Spilsbury: Needs Information
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 24 lines (+2/-3)1 file modifiedplugins/showmouse/src/showmouse.cpp (+2/-3)
| Changed in compiz: | |
| assignee: | nobody → MC Return (mc-return) |
| status: | New → In Progress |
| Changed in compiz: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in compiz (Ubuntu): | |
| status: | New → Fix Released |
| Changed in compiz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package compiz - 1:0.9.9~
---------------
compiz (1:0.9.
[ Marco Trevisan (Treviño) ]
* Spread - Window glow is incorrectly painted in the screen when
switching spreaded application (LP: #1109805)
[ MC Return ]
* Coverity MISSING_BREAK - CID 12463 (LP: #1101561)
* Thumbnail plugin: Window title text is rendered into transparency
and glow/background are too large (LP: #1099100)
* Showmouse plugin code: Needs cleanup (LP: #1105969)
* Coverity SECURE_CODING - CID 10019 (LP: #957582)
* Coverity SECURE_CODING - CID 12511 (LP: #1101605)
* Coverity SECURE_CODING - CID 12512 (LP: #1101571)
* Keyboard shortcut overlay says Ctrl+Super+Down "minimises" the
current window, but it doesn't (LP: #966099)
* Coverity SECURE_CODING - CID 10020 (LP: #957587)
* Coverity SECURE_CODING - CID 12529 (LP: #1101641)
* Coverity MISSING_BREAK - CID 12464 (LP: #1101549)
* Coverity SECURE_CODING - CID 12519 (LP: #1101565)
* Coverity SECURE_CODING - CID 12516 (LP: #1101499)
* [GLES] Showmouse plugin needs port to OpenGL|ES (LP: #1106270)
[ Automatic PS uploader ]
* Automatic snapshot from revision 3594
-- Automatic PS uploader <email address hidden> Mon, 04 Feb 2013 04:01:58 +0000