Coverity FORWARD_NULL - CID 12445 - plugins/animation/src/animation.cpp - in function: PrivateAnimScreen::initiateCloseAnim(PrivateAnimWindow *) - Comparing "effectToBePlayed" to null implies that "effectToBePlayed" might be null.

Bug #1101573 reported by Product Strategy Coverity Bug Uploader
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Fix Released
Medium
Stephen M. Webb
0.9.9
Won't Fix
High
Unassigned
compiz (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 12445
Checker: FORWARD_NULL
Category: No category available
CWE definition: http://cwe.mitre.org/data/definitions/476.html
File: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/animation/src/animation.cpp
Function: PrivateAnimScreen::initiateCloseAnim(PrivateAnimWindow *)
Code snippet:
1930 AnimEffect effectToBePlayed =
1931 getActualEffect (chosenEffect, AnimEventClose);
1932
1933 // handle empty random effect list
CID 12445 - FORWARD_NULL
Comparing "effectToBePlayed" to null implies that "effectToBePlayed" might be null.
1934 if (effectToBePlayed && effectToBePlayed == AnimEffectNone)
1935 {
1936 aw->mState = aw->mNewState;
1937 return;
1938 }
1939

Related branches

Revision history for this message
Product Strategy Coverity Bug Uploader (coverity-uploader) wrote : compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/animation/src/animation.cpp

Source file with Coverity annotations.

Changed in compiz:
importance: Undecided → High
MC Return (mc-return)
summary: - Coverity FORWARD_NULL - CID 12445
+ Coverity FORWARD_NULL - CID 12445 - plugins/animation/src/animation.cpp
+ - in function: PrivateAnimScreen::initiateCloseAnim(PrivateAnimWindow *)
+ - Comparing "effectToBePlayed" to null implies that "effectToBePlayed"
+ might be null.
Changed in compiz:
milestone: none → 0.9.10.0
MC Return (mc-return)
Changed in compiz:
milestone: 0.9.10.0 → 0.9.11.0
Stephen M. Webb (bregma)
Changed in compiz:
status: New → Confirmed
milestone: 0.9.11.0 → 0.9.12.1
Stephen M. Webb (bregma)
Changed in compiz:
milestone: 0.9.12.1 → 0.9.12.2
Stephen M. Webb (bregma)
Changed in compiz:
status: Confirmed → In Progress
importance: High → Medium
assignee: nobody → Stephen M. Webb (bregma)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.12.1+15.04.20150330-0ubuntu1

---------------
compiz (1:0.9.12.1+15.04.20150330-0ubuntu1) vivid; urgency=medium

  [ Chris Townsend ]
  * Change default behavior of focus-follows-mouse where the desktop
    will get focus when the mouse is over it. Also add option to allow
    old behavior. (LP: #1427636)
  * Clear out the lastMask vars when using the mouse to resize. (LP:
    #1348254)

  [ Eleni Maria Stea ]
  * Minor optimisation fix: Replaced glLoadIdentity, glMultMatrixf with
    glLoadMatrixf to avoid the unnecessary matrix multiplication:
    identity * some projection matrix

  [ Kevin Lange ]
  * WinRules plugin: boost arbitrary window size limits to something
    more reasonable (LP: #1431923)

  [ Stephen M. Webb ]
  * animations plugin: fixed a potential null pointer dereference (LP:
    #1101573)
 -- CI Train Bot <email address hidden> Mon, 30 Mar 2015 15:58:21 +0000

Changed in compiz (Ubuntu):
status: New → Fix Released
Stephen M. Webb (bregma)
Changed in compiz:
status: In Progress → Fix Committed
Stephen M. Webb (bregma)
Changed in compiz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.