Coverity FORWARD_NULL - CID 12451 - plugins/animation/src/extensionplugin.cpp - in function: ExtensionPluginAnimation::paintShouldSkipWindow(CompWindow *) - Dynamic cast to pointer "dynamic_cast <RestackAnim *>(aw->curAnimation())" can return NULL. Passing null pointer "dynamic_cast <RestackAnim *>(aw->curAnimation())" to function "RestackAnim::paintedElsewhere()", which dereferences it. (The dereference happens because this is a virtual function call.)

Bug #1101553 reported by Product Strategy Coverity Bug Uploader
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Confirmed
Medium
Unassigned
0.9.9
Won't Fix
High
Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 12451
Checker: FORWARD_NULL
Category: dynamic_cast
CWE definition: http://cwe.mitre.org/data/definitions/476.html
File: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/animation/src/extensionplugin.cpp
Function: ExtensionPluginAnimation::paintShouldSkipWindow(CompWindow *)
Code snippet:
110 data->mVisitCount++;
111
112 // If the window is (to be) painted somewhere other than in its
113 // original stacking order, we don't need to paint it now.
CID 12451 - FORWARD_NULL
Dynamic cast to pointer "dynamic_cast <RestackAnim *>(aw->curAnimation())" can return NULL.
Passing null pointer "dynamic_cast <RestackAnim *>(aw->curAnimation())" to function "RestackAnim::paintedElsewhere()", which dereferences it. (The dereference happens because this is a virtual function call.)
114 if (aw->curAnimation ()->info ()->isRestackAnim &&
115 dynamic_cast<RestackAnim *> (aw->curAnimation ())->paintedElsewhere ())
116 return true;
117 }
118 return false;
119 }

Revision history for this message
Product Strategy Coverity Bug Uploader (coverity-uploader) wrote : compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/animation/src/extensionplugin.cpp

Source file with Coverity annotations.

Changed in compiz:
importance: Undecided → High
MC Return (mc-return)
summary: - Coverity FORWARD_NULL - CID 12451
+ Coverity FORWARD_NULL - CID 12451 -
+ plugins/animation/src/extensionplugin.cpp - in function:
+ ExtensionPluginAnimation::paintShouldSkipWindow(CompWindow *) - Dynamic
+ cast to pointer "dynamic_cast <RestackAnim *>(aw->curAnimation())" can
+ return NULL. Passing null pointer "dynamic_cast <RestackAnim
+ *>(aw->curAnimation())" to function "RestackAnim::paintedElsewhere()",
+ which dereferences it. (The dereference happens because this is a
+ virtual function call.)
Changed in compiz:
milestone: none → 0.9.10.0
MC Return (mc-return)
Changed in compiz:
milestone: 0.9.10.0 → 0.9.11.0
Stephen M. Webb (bregma)
Changed in compiz:
milestone: 0.9.11.0 → 0.9.12.1
Stephen M. Webb (bregma)
Changed in compiz:
status: New → Confirmed
importance: High → Medium
Stephen M. Webb (bregma)
Changed in compiz:
milestone: 0.9.12.1 → 0.9.12.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.