Coverity CHECKED_RETURN - CID 12416 - src/session.cpp - in function: iceNewConnection(_IceConn *, void *, int, void **) - Calling function "fcntl(IceConnectionNumber(connection), 2, fcntl(IceConnectionNumber(connection), 1, 0) | 1)" without checking return value. This library function may fail and return an error code. No check of the return value of "fcntl(IceConnectionNumber(connection), 2, fcntl(IceConnectionNumber(connection), 1, 0) | 1)".

Bug #1101490 reported by Product Strategy Coverity Bug Uploader
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
New
Medium
Unassigned
0.9.9
New
Medium
Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 12416
Checker: CHECKED_RETURN
Category: library_function
CWE definition: http://cwe.mitre.org/data/definitions/252.html
File: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/session.cpp
Function: iceNewConnection(_IceConn *, void *, int, void **)
Code snippet:
370 SM_DEBUG (printf ("ICE connection opening\n"));
371
372 /* Make sure we don't pass on these file descriptors to any
373 exec'ed children */
CID 12416 - CHECKED_RETURN
Calling function "fcntl(IceConnectionNumber(connection), 2, fcntl(IceConnectionNumber(connection), 1, 0) | 1)" without checking return value. This library function may fail and return an error code.
No check of the return value of "fcntl(IceConnectionNumber(connection), 2, fcntl(IceConnectionNumber(connection), 1, 0) | 1)".
374 fcntl (IceConnectionNumber (connection), F_SETFD,
375 fcntl (IceConnectionNumber (connection),
376 F_GETFD,0) | FD_CLOEXEC);
377
378 iceWatchFdHandle = screen->addWatchFd (IceConnectionNumber (connection),
379 POLLIN | POLLPRI | POLLHUP | POLLERR,

Revision history for this message
Product Strategy Coverity Bug Uploader (coverity-uploader) wrote : compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/session.cpp

Source file with Coverity annotations.

Changed in compiz:
importance: Undecided → Medium
MC Return (mc-return)
summary: - Coverity CHECKED_RETURN - CID 12416
+ Coverity CHECKED_RETURN - CID 12416 - src/session.cpp - in function:
+ iceNewConnection(_IceConn *, void *, int, void **) - Calling function
+ "fcntl(IceConnectionNumber(connection), 2,
+ fcntl(IceConnectionNumber(connection), 1, 0) | 1)" without checking
+ return value. This library function may fail and return an error code.
+ No check of the return value of "fcntl(IceConnectionNumber(connection),
+ 2, fcntl(IceConnectionNumber(connection), 1, 0) | 1)".
Changed in compiz:
milestone: none → 0.9.10.0
Changed in compiz:
milestone: 0.9.10.0 → 0.9.10.2
MC Return (mc-return)
Changed in compiz:
milestone: 0.9.10.2 → 0.9.11.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.