Coverity CHECKED_RETURN - CID 12408 - src/privatescreen/tests/test-privatescreen.cpp - in function: privatescreen_ButtonPressEventManagementTest_NoTriggerOnMismatchedButtonState_Test::TestBody() - Calling function "CompOption::set(CompOption::Value &)" without checking return value (as is done elsewhere). No check of the return value of "option.set(value)".

Bug #1101435 reported by Product Strategy Coverity Bug Uploader
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz
Triaged
Medium
Unassigned
0.9.9
Won't Fix
Medium
Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 12408
Checker: CHECKED_RETURN
Category: No category available
CWE definition: http://cwe.mitre.org/data/definitions/252.html
File: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/privatescreen/tests/test-privatescreen.cpp
Function: privatescreen_ButtonPressEventManagementTest_NoTriggerOnMismatchedButtonState_Test::TestBody()
Code snippet:
1153 CompOption::Value value (action);
1154 cps::EventManager eventManager;
1155 ce::EventArguments arguments;
1156
CID 12408 - CHECKED_RETURN
Calling function "CompOption::set(CompOption::Value &)" without checking return value (as is done elsewhere 1171 out of 1219 times).
No check of the return value of "option.set(value)".
1157 option.set (value);
1158 option.value ().action ().setInitiate (initiate);
1159 option.value ().action ().setState (CompAction::StateInitButton);
1160 ca::setActionActiveState (option.value ().action (), true);
1161
1162 EXPECT_CALL (triggerableAction, matchEventState (testingButtonState, 0))

Revision history for this message
Product Strategy Coverity Bug Uploader (coverity-uploader) wrote : compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/privatescreen/tests/test-privatescreen.cpp

Source file with Coverity annotations.

Changed in compiz:
importance: Undecided → Medium
MC Return (mc-return)
summary: - Coverity CHECKED_RETURN - CID 12408
+ Coverity CHECKED_RETURN - CID 12408 - src/privatescreen/tests/test-
+ privatescreen.cpp - in function:
+ privatescreen_ButtonPressEventManagementTest_NoTriggerOnMismatchedButtonState_Test::TestBody()
+ - Calling function "CompOption::set(CompOption::Value &)" without
+ checking return value (as is done elsewhere). No check of the return
+ value of "option.set(value)".
Changed in compiz:
milestone: none → 0.9.10.0
MC Return (mc-return)
Changed in compiz:
milestone: 0.9.10.0 → 0.9.11.0
Stephen M. Webb (bregma)
Changed in compiz:
status: New → Triaged
assignee: nobody → Stephen M. Webb (bregma)
milestone: 0.9.11.0 → 0.9.12.1
Stephen M. Webb (bregma)
Changed in compiz:
assignee: Stephen M. Webb (bregma) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.