Default blacklist string shouldn't contain double escape
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Compiz |
Fix Released
|
Undecided
|
Timo Jyrinki | ||
0.9.8 |
Fix Released
|
Undecided
|
Timo Jyrinki | ||
Compiz Core |
Fix Released
|
Undecided
|
Timo Jyrinki | ||
compiz (Ubuntu) |
Fix Released
|
Undecided
|
Timo Jyrinki | ||
Precise |
Fix Released
|
Undecided
|
Timo Jyrinki |
Bug Description
Note: similar to bug #1089246, this SRU only affects precise since on quantal/raring it wouldn't have an effect.
[Impact]
Incorrect default setting doesn't have the wanted effect of functional blacklist on precise, because of character escaping problems.
[Test Case]
The test case relies on a bug/feature of Intel driver that on modern Intel hardware like sandy bridge / ivy bridge, tear-free video playback is not possible without compositing if the video player doesn't use vsync itself. Thus tearing can be seen as an indication if unredirection is in effect or not.
0. Have intel hardware on Ubuntu 12.04 LTS, with which this is easiest to test
1. In CCSM, set Composite -> unredirect_match to '(any)', ie. remove everything that comes after that, that would normally prevent unredirection in common video players.
2. Open http://
3. Expected result: no tearing, because blacklist is in effect and prevents unredirection on Intel (and nouveau) regardless of the match setting
Note: radeon always has tearfree Xv output, so you can't use a similar test and changing the blacklist string to include 'AMD' without forcing non-Xv X11 output
[Regression Potential]
Very low. Theoretically too excessive blacklisting could restore current precise behavior.
---
The blacklist default option in a true precise environment - the only environment it's supposed to have an effect with its default setting - is not working. It seems that the default unredirect_
This one, the current default doesn't work:
(nouveau|
Either one of these works instead:
(nouveau|
(nouveau|
Related branches
- Łukasz Zemczak: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 25 lines (+2/-2)2 files modifiedplugins/opengl/opengl.xml.in (+1/-1)
plugins/opengl/src/blacklist/tests/test-blacklist.cpp (+1/-1)
- Łukasz Zemczak: Approve
-
Diff: 25 lines (+2/-2)2 files modifiedplugins/opengl/opengl.xml.in (+1/-1)
plugins/opengl/src/blacklist/tests/test-blacklist.cpp (+1/-1)
description: | updated |
description: | updated |
description: | updated |
Changed in compiz: | |
status: | New → Fix Committed |
description: | updated |
Changed in compiz-core: | |
status: | New → Fix Committed |
Changed in compiz (Ubuntu): | |
status: | New → Fix Committed |
Changed in compiz: | |
milestone: | none → 0.9.9.0 |
Changed in compiz-core: | |
milestone: | none → 0.9.7.14 |
Changed in compiz: | |
assignee: | nobody → Timo Jyrinki (timo-jyrinki) |
Changed in compiz-core: | |
assignee: | nobody → Timo Jyrinki (timo-jyrinki) |
Changed in compiz (Ubuntu): | |
assignee: | nobody → Timo Jyrinki (timo-jyrinki) |
Changed in compiz (Ubuntu Precise): | |
assignee: | nobody → Timo Jyrinki (timo-jyrinki) |
Changed in compiz: | |
status: | Fix Committed → Fix Released |
Changed in compiz-core: | |
status: | Fix Committed → Fix Released |
Hello Timo, or anyone else affected,
Accepted compiz into precise-proposed. The package will build now and be available at http:// launchpad. net/ubuntu/ +source/ compiz/ 1:0.9.7. 12-0ubuntu1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed. In either case, details of your testing will help us make a better decision.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance!