[GLES] Water Effect plug-in: The plug-in now needs OpenGL->Framebuffer object option to be enabled to work, but the user is not informed about that

[MC Return]

If the "Framebuffer object" option in the OpenGL Compiz plug-in gets deactivated, which fixes many other problems like visual lag and general slowness on certain hardware, the water plug-in silently fails to work.
The user should somewhere be informed that the water plug-in needs this option to be enabled to run, ideally a choice should be presented to the user.

[Daniel van Vugt (vanvugt)]

Sounds like we just want an additional check for GL::fboEnabled and log message after:

    const char *missing = NULL;
    if (!GL::fboSupported)
        missing = "framebuffer objects";
    if (!GL::vboSupported)
        missing = "vertexbuffer objects";
    if (!GL::shaders)
        missing = "GLSL";
    if (missing)
    {
        compLogMessage ("water", CompLogLevelError,
            "Missing hardware support for %s", missing);
        return false;
    }

[Ubuntu QA Website (ubuntuqa)]

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
http://iso.qa.ubuntu.com/qatracker/reports/bugs/1066547

[MC Return (mc-return)]

Fix committed into lp:compiz at revision 3689.

[MC Return (mc-return)]

I apologize for forgetting to link the MP to this bugreport earlier and for the missing info regarding this fix in the commit message of the MP.

[Stephen M. Webb (bregma)]

Fix Released in Compiz Compiz 0.9.10.0.