[regression-r3320] firepaint doesn't paint any fire any more

Bug #1048505 reported by Daniel van Vugt on 2012-09-10
36
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Compiz
Low
Michail Bitzes
0.9.8
Low
Michail Bitzes
compiz (Ubuntu)
Low
Michail Bitzes
Quantal
Undecided
Unassigned

Bug Description

[Impact]

An existing compiz plugins stopped working. It is important for users that might have been using the plugin before.

[Test Case]

1. Open ccsm
2. Enable the firepaint plugin
3. Use the initiate button/keybinding
   - Make sure there is a fire effect (or other particle-like effect)

[Regression Potential]

No obvious regression potential.

Original description

firepaint doesn't seem to do anything any more, other than dim the screen.

Strange, because I tested it a couple of times in recent months.

Related branches

Daniel van Vugt (vanvugt) wrote :

I think I know when this broke actually...

Changed in compiz:
assignee: nobody → Daniel van Vugt (vanvugt)
Changed in compiz:
assignee: Daniel van Vugt (vanvugt) → nobody
Daniel van Vugt (vanvugt) wrote :

Bisected. The cause is indeed the gles2 merge:

revno: 3320 [merge]
author: Daniel van Vugt <email address hidden>, Travis Watkins <email address hidden>, Sam Spilsbury <email address hidden>, smspillaz <email address hidden>, Alexandros Frantzis <email address hidden>,
committer: Tarmac
branch nick: compiz
timestamp: Wed 2012-08-22 08:46:59 -0400
message:
  This branch contains the code to make compiz work on GLES. This includes
  several changes to the compiz API.

I'm using intel graphics right now and it doesn't work. But I'm sure it worked in the gles2 branch at least with other drivers.

tags: added: gles
Michail Bitzes (bitzesmichail) wrote :

Hi, I got firepaint to work. (tested on Intel graphics).

MC Return (mc-return) wrote :

@bitzesmichail: Wow, great news !

MC Return (mc-return) on 2012-12-29
summary: - firepaint doesn't paint any fire any more
+ [regression-r3320] firepaint doesn't paint any fire any more
Changed in compiz:
milestone: none → 0.9.9.0
Changed in compiz (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Changed in compiz:
assignee: nobody → Michail Bitzes (bitzesmichail)
status: Triaged → In Progress
Changed in compiz (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Michail Bitzes (bitzesmichail)

The attachment "firepaint.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Changed in compiz:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt) wrote :

Fix committed into lp:compiz at revision 3534, scheduled for release in Compiz 0.9.9.0
Fix committed into lp:compiz/0.9.8 at revision 3431, scheduled for release in Compiz 0.9.8.8

Changed in compiz (Ubuntu):
status: In Progress → Fix Committed
Michail Bitzes (bitzesmichail) wrote :

I am doing some work on porting firepaint to OpenGL|ES. (I split the GL_QUADS to GL_TRIANGLES and replaced glDrawArrays etc. with GLVertexBuffer). I will post it when I get free time from university commitments.

Daniel van Vugt (vanvugt) wrote :

Nice, thanks Michail.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package compiz - 1:0.9.9~daily13.01.14-0ubuntu1

---------------
compiz (1:0.9.9~daily13.01.14-0ubuntu1) raring; urgency=low

  [ sampo555 ]
  * compiz crashed with SIGSEGV in DodgeAnim::applyDodgeTransform() (LP:
    #1048840)
  * compiz crashing if window un-/minimize animation is "Random" (LP:
    #1098185)

  [ Daniel van Vugt ]
  * Several leaks in new GLProgram from compileProgram() from
    GLScreen::getProgram() from GLWindowAutoProgram::getProgram() (LP:
    #1097644)

  [ Sam Spilsbury ]
  * Several leaks in ccsIntegratedSettingListAppend() ... from
    ccsGNOMEIntegrationBackendGetIntegratedSetting() from readSetting
    (gsettings.c:375) (LP: #1097661)

  [ MC Return ]
  * Thumbnail Window Previews: Flickering of background/glow and window
    title text (LP: #1098758)

  [ Automatic PS uploader ]
  * Automatic snapshot from revision 3561
 -- Automatic PS uploader <email address hidden> Mon, 14 Jan 2013 04:03:09 +0000

Changed in compiz (Ubuntu):
status: Fix Committed → Fix Released
description: updated
Changed in compiz:
status: Fix Committed → Fix Released

Hello Daniel, or anyone else affected,

Accepted compiz into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/compiz/1:0.9.8.6+bzr3433-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in compiz (Ubuntu Quantal):
status: New → Fix Committed
tags: added: verification-needed
Sami Jaktholm (sjakthol) wrote :

Firepaint works again with compiz from proposed.

tags: added: verification-done
removed: verification-needed
Stephen M. Webb (bregma) wrote :

marking as closed (0.9.8 series is obsolete)

Changed in compiz (Ubuntu Quantal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers