| 2012-06-02 09:03:01 |
Sam Spilsbury |
description |
gtk-window-decorator can crash if on startup, a window is initially undecorated, since it will try to get its geometry regardless of the decoration state. |
gtk-window-decorator can crash if on startup, a window is initially undecorated, since it will try to get its geometry regardless of the decoration state.
#0 meta_get_decoration_geometry (d=0x817d488, theme=0x80f1cb0,
flags=0xbfffdacc, fgeom=0xbfffd68c, button_layout=0xbfffda1c,
frame_type=META_FRAME_TYPE_NORMAL, clip=0xbfffdabc)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/metacity.c:550
#1 0x08057dbd in meta_get_event_window_position (d=0x817d488, i=0, j=0,
width=1213, height=910, x=0xbfffdb60, y=0xbfffdb64, w=0xbfffdb68,
h=0xbfffdb6c)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/metacity.c:1271
#2 0x08060283 in update_event_windows (win=0x817a800)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/decorator.c:283
#3 0x0805ebe2 in add_frame_window (win=0x817a800, frame=14684311, mode=0)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/wnck.c:427
#4 0x0805f258 in window_opened (screen=0x80e5070, win=0x817a800)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/wnck.c:781
#5 0xb7778690 in g_cclosure_marshal_VOID__OBJECTv ()
from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0 |
|
| 2012-06-21 15:11:28 |
Łukasz Zemczak |
description |
gtk-window-decorator can crash if on startup, a window is initially undecorated, since it will try to get its geometry regardless of the decoration state.
#0 meta_get_decoration_geometry (d=0x817d488, theme=0x80f1cb0,
flags=0xbfffdacc, fgeom=0xbfffd68c, button_layout=0xbfffda1c,
frame_type=META_FRAME_TYPE_NORMAL, clip=0xbfffdabc)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/metacity.c:550
#1 0x08057dbd in meta_get_event_window_position (d=0x817d488, i=0, j=0,
width=1213, height=910, x=0xbfffdb60, y=0xbfffdb64, w=0xbfffdb68,
h=0xbfffdb6c)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/metacity.c:1271
#2 0x08060283 in update_event_windows (win=0x817a800)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/decorator.c:283
#3 0x0805ebe2 in add_frame_window (win=0x817a800, frame=14684311, mode=0)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/wnck.c:427
#4 0x0805f258 in window_opened (screen=0x80e5070, win=0x817a800)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/wnck.c:781
#5 0xb7778690 in g_cclosure_marshal_VOID__OBJECTv ()
from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0 |
[Test Case]
No obvious test case for verifying the bug fix. Crash was hard to directly reproduce, so just ensure that the gtk-window-decorator does not crash during usage and start/restart
[Regression Potential]
Small change, no real regression potential
Original description:
gtk-window-decorator can crash if on startup, a window is initially undecorated, since it will try to get its geometry regardless of the decoration state.
#0 meta_get_decoration_geometry (d=0x817d488, theme=0x80f1cb0,
flags=0xbfffdacc, fgeom=0xbfffd68c, button_layout=0xbfffda1c,
frame_type=META_FRAME_TYPE_NORMAL, clip=0xbfffdabc)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/metacity.c:550
#1 0x08057dbd in meta_get_event_window_position (d=0x817d488, i=0, j=0,
width=1213, height=910, x=0xbfffdb60, y=0xbfffdb64, w=0xbfffdb68,
h=0xbfffdb6c)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/metacity.c:1271
#2 0x08060283 in update_event_windows (win=0x817a800)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/decorator.c:283
#3 0x0805ebe2 in add_frame_window (win=0x817a800, frame=14684311, mode=0)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/wnck.c:427
#4 0x0805f258 in window_opened (screen=0x80e5070, win=0x817a800)
at /home/smspillaz/Source/Compiz/dev/dev/merges/compiz/proposed/compiz.fix_1002606/gtk/window-decorator/wnck.c:781
#5 0xb7778690 in g_cclosure_marshal_VOID__OBJECTv ()
from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0 |
|
