Some plugins no longer build due to undefined DEG2RAD

Bug #918554 reported by Daniel van Vugt on 2012-01-19
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Compiz Core
Medium
Daniel van Vugt
Compiz CubeAddon Plugin
Fix Released
Critical
Alan Griffiths
Compiz Extra Plugins
Critical
Daniel van Vugt
Compiz Main Plugins
Critical
Alan Griffiths

Bug Description

The macro DEG2RAD is no longer universally defined as has now moved to core/deg2rad.h. But some plugins don't know this yet...

lp:compiz-expo-plugin / compiz-plugins-main
lp:compiz-cubeaddon-plugin / compiz-plugins-extra

This is due to:
https://code.launchpad.net/~alan-griffiths/compiz-core/fix-headers/+merge/89075

One could resolve this by simply including core/deg2rad.h in the affected code. But looking at deg2rad.h I suggest the file shouldn't exist at all and should be removed from compiz-core. And plugins should replace DEG2RAD with an explicit (M_PI / 180.0f) which is more readable and reduces coupling.

Related branches

description: updated
Changed in compiz-core:
importance: Undecided → High
Changed in compiz-cubeaddon-plugin:
importance: Undecided → High
Changed in compiz-expo-plugin:
importance: Undecided → High
Daniel van Vugt (vanvugt) wrote :

See also, other build failures described in bug 915236.

Changed in compiz-cubeaddon-plugin:
assignee: nobody → Alan Griffiths (alan-griffiths)
Changed in compiz-expo-plugin:
assignee: nobody → Alan Griffiths (alan-griffiths)
Changed in compiz-core:
assignee: nobody → Alan Griffiths (alan-griffiths)
Changed in compiz-cubeaddon-plugin:
status: New → In Progress
Changed in compiz-cubeaddon-plugin:
importance: High → Critical
Changed in compiz-expo-plugin:
importance: High → Critical
Changed in compiz-cubeaddon-plugin:
status: In Progress → Fix Committed
Changed in compiz-expo-plugin:
status: New → Fix Committed
Changed in compiz-core:
assignee: Alan Griffiths (alan-griffiths) → Daniel van Vugt (vanvugt)
importance: High → Medium
status: New → In Progress
milestone: none → 0.9.7.0
Changed in compiz-core:
status: In Progress → Fix Committed
affects: compiz-expo-plugin → compiz-plugins-main
Changed in compiz-plugins-main:
milestone: none → 0.9.7.0
Changed in compiz-plugins-extra:
status: New → Triaged
importance: Undecided → Critical
milestone: none → 0.9.7.0
Daniel van Vugt (vanvugt) wrote :

Fix committed to lp:compiz-plugins-extra revision 5.

Changed in compiz-plugins-extra:
status: Triaged → Fix Committed
assignee: nobody → Daniel van Vugt (vanvugt)
Changed in compiz-core:
status: Fix Committed → Fix Released
Changed in compiz-plugins-extra:
status: Fix Committed → Fix Released
Changed in compiz-plugins-main:
status: Fix Committed → Fix Released
Changed in compiz-cubeaddon-plugin:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers