Activity log for bug #925867

Date Who What changed Old value New value Message
2012-02-03 05:22:07 Daniel van Vugt bug added bug
2012-02-03 05:22:07 Daniel van Vugt attachment added grid-breaks-window-granularity.ogv https://bugs.launchpad.net/bugs/925867/+attachment/2709325/+files/grid-breaks-window-granularity.ogv
2012-02-03 05:23:32 Daniel van Vugt compiz-grid-plugin: importance Undecided Medium
2012-02-03 05:31:05 Daniel van Vugt summary Window resize granularity is lost after being semi-maximized by the Grid plugin [regression] Window resize granularity is lost after being semi-maximized by the Grid plugin
2012-02-03 05:31:13 Daniel van Vugt tags regression-update
2012-02-03 05:31:32 Daniel van Vugt bug task added compiz-plugins-main (Ubuntu)
2012-02-03 05:31:48 Daniel van Vugt compiz-grid-plugin: status New Triaged
2012-02-03 05:40:23 Daniel van Vugt description When you resize a (new) terminal window, it only resizes in increments of the character size. This is correct behaviour. However after the Grid plugin has touched a window, it loses its resize increments/granularity. Video attached. I suspect this is the cause (in grid.cpp): /* Be evil */ if (cw->sizeHints ().flags & PResizeInc) { gw->sizeHintsFlags |= PResizeInc; gw->window->sizeHints ().flags &= ~(PResizeInc); } and it seems the restore code to undo the above hack never gets called: if (gw->isGridMaximized & !(cw->state () & MAXIMIZE_STATE)) { gw->window->sizeHints ().flags |= gw->sizeHintsFlags; gw->isGridMaximized = false; When you resize a (new) terminal window, it only resizes in increments of the character size. This is correct behaviour. However after the Grid plugin has touched a window, it loses its resize increments/granularity. Video attached. TESTCASE: 1. Open a Terminal. 2. Resize it. Verify that it only resizes in granular increments. 3. Drag the window to the left or right of the screen to trigger Grid. 4. Restore the window. 5. Resize it again. Notice the granular increments are gone. That is the bug. Expected result: 5. Resize it again. Verify that it only resizes in granular increments. I suspect this is the cause (in grid.cpp):                 /* Be evil */                 if (cw->sizeHints ().flags & PResizeInc)                 {                     gw->sizeHintsFlags |= PResizeInc;                     gw->window->sizeHints ().flags &= ~(PResizeInc);                 } and it seems the restore code to undo the above hack never gets called:     if (gw->isGridMaximized & !(cw->state () & MAXIMIZE_STATE))     {         gw->window->sizeHints ().flags |= gw->sizeHintsFlags;         gw->isGridMaximized = false;
2012-02-03 05:40:33 Daniel van Vugt tags regression-update regression-update testcase
2012-02-03 05:43:20 Daniel van Vugt summary [regression] Window resize granularity is lost after being semi-maximized by the Grid plugin [regression] Window resize granularity is lost when restored after using Grid
2012-02-05 08:45:25 Daniel van Vugt affects compiz-grid-plugin compiz-plugins-main
2012-03-01 02:37:25 Launchpad Janitor compiz-plugins-main (Ubuntu): status New Confirmed
2012-03-01 02:37:46 Daniel van Vugt bug task added compiz-grid-plugin
2012-03-01 02:37:59 Daniel van Vugt compiz-grid-plugin: status New Triaged
2012-03-01 02:38:08 Daniel van Vugt compiz-grid-plugin: importance Undecided Medium
2012-05-18 08:10:29 Sam Spilsbury compiz: importance Undecided Medium
2012-05-18 08:10:29 Sam Spilsbury compiz: status New Triaged
2012-06-16 15:35:06 Carlos Fuentes bug added subscriber Carlos Fuentes
2013-01-14 21:11:37 Launchpad Janitor compiz (Ubuntu): status New Fix Released
2013-01-20 12:44:14 Launchpad Janitor branch linked lp:~sampo555/compiz/fix-878516
2013-01-22 03:14:16 Daniel van Vugt compiz: milestone 0.9.9.0
2013-01-22 03:14:19 Daniel van Vugt compiz: status Triaged In Progress
2013-01-22 03:14:27 Daniel van Vugt compiz: assignee sampo555 (sampo555)
2013-01-22 03:14:34 Daniel van Vugt compiz (Ubuntu): status Fix Released In Progress
2013-01-22 03:14:38 Daniel van Vugt compiz (Ubuntu): importance Undecided Medium
2013-01-22 03:14:50 Daniel van Vugt compiz (Ubuntu): assignee sampo555 (sampo555)
2013-01-23 06:10:21 Daniel van Vugt compiz: milestone 0.9.9.0 0.9.9.2
2013-01-23 06:12:56 Daniel van Vugt compiz: milestone 0.9.9.2 0.9.9.0
2013-01-23 11:47:24 PS Jenkins bot compiz: status In Progress Fix Committed
2013-01-24 01:12:31 Daniel van Vugt compiz (Ubuntu): status In Progress Fix Committed
2013-01-24 11:55:25 Daniel van Vugt compiz: status Fix Committed Fix Released
2013-01-25 17:54:12 Launchpad Janitor compiz (Ubuntu): status Fix Committed Fix Released
2013-03-26 02:59:13 Launchpad Janitor branch linked lp:ubuntu/compiz