Activity log for bug #918554

Date Who What changed Old value New value Message
2012-01-19 06:18:19 Daniel van Vugt bug added bug
2012-01-19 06:18:36 Daniel van Vugt bug task added compiz-cubeaddon-plugin
2012-01-19 06:18:56 Daniel van Vugt bug task added compiz-core
2012-01-19 06:19:50 Daniel van Vugt description The macro DEG2RAD is no longer universally defined as has now moved to core/deg2rad.h. But some plugins don't know this yet... lp:compiz-expo-plugin / compiz-plugins-main lp:compiz-cubeaddon-plugin / compiz-plugins-extra One could resolve this by simply including core/deg2rad.h in the affected code. But looking at deg2rad.h I suggest the file shouldn't exist at all and should be removed from compiz-core. And plugins should replace DEG2RAD with an explicit (M_PI / 180.0f) which is more readable and reduces coupling. The macro DEG2RAD is no longer universally defined as has now moved to core/deg2rad.h. But some plugins don't know this yet... lp:compiz-expo-plugin / compiz-plugins-main lp:compiz-cubeaddon-plugin / compiz-plugins-extra This is due to: https://code.launchpad.net/~alan-griffiths/compiz-core/fix-headers/+merge/89075 One could resolve this by simply including core/deg2rad.h in the affected code. But looking at deg2rad.h I suggest the file shouldn't exist at all and should be removed from compiz-core. And plugins should replace DEG2RAD with an explicit (M_PI / 180.0f) which is more readable and reduces coupling.
2012-01-19 06:21:10 Daniel van Vugt compiz-core: importance Undecided High
2012-01-19 06:21:14 Daniel van Vugt compiz-cubeaddon-plugin: importance Undecided High
2012-01-19 06:21:17 Daniel van Vugt compiz-expo-plugin: importance Undecided High
2012-01-19 06:24:39 Daniel van Vugt bug added subscriber Alan Griffiths
2012-01-19 09:54:33 Alan Griffiths compiz-cubeaddon-plugin: assignee Alan Griffiths (alan-griffiths)
2012-01-19 09:54:41 Alan Griffiths compiz-expo-plugin: assignee Alan Griffiths (alan-griffiths)
2012-01-19 09:54:53 Alan Griffiths compiz-core: assignee Alan Griffiths (alan-griffiths)
2012-01-19 10:22:17 Daniel van Vugt branch linked lp:~alan-griffiths/compiz-cubeaddon-plugin/Bug-918554
2012-01-22 08:04:46 Daniel van Vugt compiz-cubeaddon-plugin: status New In Progress
2012-01-22 11:51:45 Daniel van Vugt compiz-cubeaddon-plugin: importance High Critical
2012-01-22 11:51:48 Daniel van Vugt compiz-expo-plugin: importance High Critical
2012-01-23 11:08:01 Daniel van Vugt compiz-cubeaddon-plugin: status In Progress Fix Committed
2012-01-30 04:52:00 Daniel van Vugt compiz-expo-plugin: status New Fix Committed
2012-01-30 04:53:32 Daniel van Vugt compiz-core: assignee Alan Griffiths (alan-griffiths) Daniel van Vugt (vanvugt)
2012-01-30 04:53:40 Daniel van Vugt compiz-core: importance High Medium
2012-01-30 04:53:46 Daniel van Vugt compiz-core: status New In Progress
2012-01-30 04:53:52 Daniel van Vugt compiz-core: milestone 0.9.7.0
2012-01-30 05:15:16 Daniel van Vugt branch linked lp:~vanvugt/compiz-core/fix-918554
2012-01-31 03:24:00 Daniel van Vugt compiz-core: status In Progress Fix Committed
2012-02-05 08:34:46 Daniel van Vugt affects compiz-expo-plugin compiz-plugins-main
2012-02-06 06:37:13 Daniel van Vugt compiz-plugins-main: milestone 0.9.7.0
2012-02-06 06:38:05 Daniel van Vugt bug task added compiz-plugins-extra
2012-02-06 06:38:12 Daniel van Vugt compiz-plugins-extra: status New Triaged
2012-02-06 06:38:16 Daniel van Vugt compiz-plugins-extra: importance Undecided Critical
2012-02-06 06:38:20 Daniel van Vugt compiz-plugins-extra: milestone 0.9.7.0
2012-02-06 09:40:13 Daniel van Vugt compiz-plugins-extra: status Triaged Fix Committed
2012-02-06 09:40:16 Daniel van Vugt compiz-plugins-extra: assignee Daniel van Vugt (vanvugt)
2012-02-13 14:31:21 Launchpad Janitor branch linked lp:~compiz/compcomm-plugins-main/ubuntu
2012-02-13 15:15:18 Launchpad Janitor branch linked lp:ubuntu/compiz-plugins-extra
2012-02-13 15:16:41 Launchpad Janitor branch linked lp:ubuntu/compiz-plugins-main
2012-03-03 09:41:44 Daniel van Vugt compiz-core: status Fix Committed Fix Released
2012-03-03 09:41:48 Daniel van Vugt compiz-plugins-extra: status Fix Committed Fix Released
2012-03-03 09:41:51 Daniel van Vugt compiz-plugins-main: status Fix Committed Fix Released
2012-03-03 09:42:00 Daniel van Vugt compiz-cubeaddon-plugin: status Fix Committed Fix Released