| 2012-12-17 06:46:59 |
Timo Jyrinki |
bug |
|
|
added bug |
| 2012-12-17 07:02:18 |
Timo Jyrinki |
branch linked |
|
lp:~timo-jyrinki/compiz/blacklist_remove_double_escape_from_xml |
|
| 2012-12-17 10:07:09 |
Launchpad Janitor |
branch linked |
|
lp:~timo-jyrinki/compiz/ubuntu-0.9.7.12 |
|
| 2012-12-17 10:51:36 |
Timo Jyrinki |
description |
I got to testing the blacklist feature in true precise environment, and started figuring something's off. It seems that the default unredirect_driver_blacklist in the XML contains the same double escape as the test code, while it shouldn't. So the tests succeed, but in reality one '\' needs to be removed from the XML default in order for the blacklist to work as intended. |
I got to testing the blacklist feature in true precise environment, and started figuring something's off. It seems that the default unredirect_driver_blacklist in the XML contains the same double escape as the test code. So the tests succeed, but in reality there is extra '\' in the default setting. |
|
| 2012-12-17 11:14:18 |
Timo Jyrinki |
branch linked |
|
lp:~timo-jyrinki/compiz/blacklist_remove_double_escape_from_xml2 |
|
| 2012-12-17 12:43:48 |
Timo Jyrinki |
branch unlinked |
lp:~timo-jyrinki/compiz/blacklist_remove_double_escape_from_xml |
|
|
| 2012-12-17 13:03:28 |
Timo Jyrinki |
description |
I got to testing the blacklist feature in true precise environment, and started figuring something's off. It seems that the default unredirect_driver_blacklist in the XML contains the same double escape as the test code. So the tests succeed, but in reality there is extra '\' in the default setting. |
Note: similar to bug #1089246, this SRU only affects precise since on quantal it wouldn't have an effect.
[Impact]
Incorrect default setting doesn't have the wanted effect of functional blacklist on precise, because of character escaping problems.
[Test Case]
The test case relies on a bug/feature of Intel driver that on modern Intel hardware like sandy bridge / ivy bridge, tear-free video playback is not possible without compositing if the video player doesn't use vsync itself. Thus tearing can be seen as an indication if unredirection is in effect or not.
0. Have intel hardware on Ubuntu 12.04 LTS, with which this is easiest to test
1. In CCSM, set Composite -> unredirect_match to '(any)', ie. remove everything that comes after that, that would normally prevent unredirection in common video players.
2. Open http://www.youtube.com/watch?v=ZCPkOpMHB7g in Firefox and play it full screen
3. Expected result: no tearing, because blacklist is in effect and prevents unredirection on Intel (and nouveau) regardless of the match setting
[Regression Potential]
Very low. Theoretically too excessive blacklisting could restore current precise behavior.
---
The blacklist default option in a true precise environment - the only environment it's supposed to have an effect with its default setting - is not working. It seems that the default unredirect_driver_blacklist in the XML contains the same double escape as the test code. So the tests succeed, but in reality there is extra '\' in the default setting, preventing the regexp from working.
This one, the current default doesn't work:
(nouveau|Intel).*Mesa 8\\.0
Either one of these works instead:
(nouveau|Intel).*Mesa 8\.0
(nouveau|Intel).*Mesa 8.0 |
|
| 2012-12-17 13:05:27 |
Timo Jyrinki |
description |
Note: similar to bug #1089246, this SRU only affects precise since on quantal it wouldn't have an effect.
[Impact]
Incorrect default setting doesn't have the wanted effect of functional blacklist on precise, because of character escaping problems.
[Test Case]
The test case relies on a bug/feature of Intel driver that on modern Intel hardware like sandy bridge / ivy bridge, tear-free video playback is not possible without compositing if the video player doesn't use vsync itself. Thus tearing can be seen as an indication if unredirection is in effect or not.
0. Have intel hardware on Ubuntu 12.04 LTS, with which this is easiest to test
1. In CCSM, set Composite -> unredirect_match to '(any)', ie. remove everything that comes after that, that would normally prevent unredirection in common video players.
2. Open http://www.youtube.com/watch?v=ZCPkOpMHB7g in Firefox and play it full screen
3. Expected result: no tearing, because blacklist is in effect and prevents unredirection on Intel (and nouveau) regardless of the match setting
[Regression Potential]
Very low. Theoretically too excessive blacklisting could restore current precise behavior.
---
The blacklist default option in a true precise environment - the only environment it's supposed to have an effect with its default setting - is not working. It seems that the default unredirect_driver_blacklist in the XML contains the same double escape as the test code. So the tests succeed, but in reality there is extra '\' in the default setting, preventing the regexp from working.
This one, the current default doesn't work:
(nouveau|Intel).*Mesa 8\\.0
Either one of these works instead:
(nouveau|Intel).*Mesa 8\.0
(nouveau|Intel).*Mesa 8.0 |
Note: similar to bug #1089246, this SRU only affects precise since on quantal it wouldn't have an effect.
[Impact]
Incorrect default setting doesn't have the wanted effect of functional blacklist on precise, because of character escaping problems.
[Test Case]
The test case relies on a bug/feature of Intel driver that on modern Intel hardware like sandy bridge / ivy bridge, tear-free video playback is not possible without compositing if the video player doesn't use vsync itself. Thus tearing can be seen as an indication if unredirection is in effect or not.
0. Have intel hardware on Ubuntu 12.04 LTS, with which this is easiest to test
1. In CCSM, set Composite -> unredirect_match to '(any)', ie. remove everything that comes after that, that would normally prevent unredirection in common video players.
2. Open http://www.youtube.com/watch?v=ZCPkOpMHB7g in Firefox and play it full screen
3. Expected result: no tearing, because blacklist is in effect and prevents unredirection on Intel (and nouveau) regardless of the match setting
Note: radeon always has tearfree Xv output, so you can't use a similar test and changing the blacklist string to include 'AMD' without forcing non-Xv X11 output
[Regression Potential]
Very low. Theoretically too excessive blacklisting could restore current precise behavior.
---
The blacklist default option in a true precise environment - the only environment it's supposed to have an effect with its default setting - is not working. It seems that the default unredirect_driver_blacklist in the XML contains the same double escape as the test code. So the tests succeed, but in reality there is extra '\' in the default setting, preventing the regexp from working.
This one, the current default doesn't work:
(nouveau|Intel).*Mesa 8\\.0
Either one of these works instead:
(nouveau|Intel).*Mesa 8\.0
(nouveau|Intel).*Mesa 8.0 |
|
| 2012-12-17 13:19:54 |
Timo Jyrinki |
bug task added |
|
compiz (Ubuntu) |
|
| 2012-12-17 13:20:06 |
Timo Jyrinki |
nominated for series |
|
Ubuntu Precise |
|
| 2012-12-17 13:20:21 |
Timo Jyrinki |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2012-12-17 13:23:55 |
Timo Jyrinki |
nominated for series |
|
Ubuntu Quantal |
|
| 2012-12-18 23:07:23 |
PS Jenkins bot |
compiz: status |
New |
Fix Committed |
|
| 2012-12-19 08:19:24 |
Timo Jyrinki |
bug task added |
|
compiz-core |
|
| 2012-12-19 08:20:23 |
Timo Jyrinki |
description |
Note: similar to bug #1089246, this SRU only affects precise since on quantal it wouldn't have an effect.
[Impact]
Incorrect default setting doesn't have the wanted effect of functional blacklist on precise, because of character escaping problems.
[Test Case]
The test case relies on a bug/feature of Intel driver that on modern Intel hardware like sandy bridge / ivy bridge, tear-free video playback is not possible without compositing if the video player doesn't use vsync itself. Thus tearing can be seen as an indication if unredirection is in effect or not.
0. Have intel hardware on Ubuntu 12.04 LTS, with which this is easiest to test
1. In CCSM, set Composite -> unredirect_match to '(any)', ie. remove everything that comes after that, that would normally prevent unredirection in common video players.
2. Open http://www.youtube.com/watch?v=ZCPkOpMHB7g in Firefox and play it full screen
3. Expected result: no tearing, because blacklist is in effect and prevents unredirection on Intel (and nouveau) regardless of the match setting
Note: radeon always has tearfree Xv output, so you can't use a similar test and changing the blacklist string to include 'AMD' without forcing non-Xv X11 output
[Regression Potential]
Very low. Theoretically too excessive blacklisting could restore current precise behavior.
---
The blacklist default option in a true precise environment - the only environment it's supposed to have an effect with its default setting - is not working. It seems that the default unredirect_driver_blacklist in the XML contains the same double escape as the test code. So the tests succeed, but in reality there is extra '\' in the default setting, preventing the regexp from working.
This one, the current default doesn't work:
(nouveau|Intel).*Mesa 8\\.0
Either one of these works instead:
(nouveau|Intel).*Mesa 8\.0
(nouveau|Intel).*Mesa 8.0 |
Note: similar to bug #1089246, this SRU only affects precise since on quantal/raring it wouldn't have an effect.
[Impact]
Incorrect default setting doesn't have the wanted effect of functional blacklist on precise, because of character escaping problems.
[Test Case]
The test case relies on a bug/feature of Intel driver that on modern Intel hardware like sandy bridge / ivy bridge, tear-free video playback is not possible without compositing if the video player doesn't use vsync itself. Thus tearing can be seen as an indication if unredirection is in effect or not.
0. Have intel hardware on Ubuntu 12.04 LTS, with which this is easiest to test
1. In CCSM, set Composite -> unredirect_match to '(any)', ie. remove everything that comes after that, that would normally prevent unredirection in common video players.
2. Open http://www.youtube.com/watch?v=ZCPkOpMHB7g in Firefox and play it full screen
3. Expected result: no tearing, because blacklist is in effect and prevents unredirection on Intel (and nouveau) regardless of the match setting
Note: radeon always has tearfree Xv output, so you can't use a similar test and changing the blacklist string to include 'AMD' without forcing non-Xv X11 output
[Regression Potential]
Very low. Theoretically too excessive blacklisting could restore current precise behavior.
---
The blacklist default option in a true precise environment - the only environment it's supposed to have an effect with its default setting - is not working. It seems that the default unredirect_driver_blacklist in the XML contains the same double escape as the test code. So the tests succeed, but in reality there is extra '\' in the default setting, preventing the regexp from working.
This one, the current default doesn't work:
(nouveau|Intel).*Mesa 8\\.0
Either one of these works instead:
(nouveau|Intel).*Mesa 8\.0
(nouveau|Intel).*Mesa 8.0 |
|
| 2012-12-19 10:37:15 |
Timo Jyrinki |
branch linked |
|
lp:~timo-jyrinki/compiz-core/blacklist_remove_double_escape_from_xml2-0.9.7 |
|
| 2012-12-19 12:59:55 |
Timo Jyrinki |
compiz-core: status |
New |
Fix Committed |
|
| 2012-12-21 19:18:36 |
Adam Conrad |
bug |
|
|
added subscriber SRU Verification |
| 2012-12-21 19:18:39 |
Adam Conrad |
tags |
|
verification-needed |
|
| 2012-12-23 15:28:39 |
Miklos Juhasz |
tags |
verification-needed |
verification-done |
|
| 2013-01-02 09:38:52 |
Colin Watson |
bug task added |
|
compiz (Ubuntu Precise) |
|
| 2013-01-02 09:39:50 |
Colin Watson |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2013-01-02 09:40:18 |
Launchpad Janitor |
compiz (Ubuntu Precise): status |
New |
Fix Released |
|
| 2013-01-03 06:13:05 |
Daniel van Vugt |
compiz (Ubuntu): status |
New |
Fix Committed |
|
| 2013-01-03 06:13:18 |
Daniel van Vugt |
compiz: milestone |
|
0.9.9.0 |
|
| 2013-01-03 06:13:25 |
Daniel van Vugt |
nominated for series |
|
compiz/0.9.8 |
|
| 2013-01-03 06:13:25 |
Daniel van Vugt |
bug task added |
|
compiz/0.9.8 |
|
| 2013-01-03 06:13:37 |
Daniel van Vugt |
compiz-core: milestone |
|
0.9.7.14 |
|
| 2013-01-03 06:13:42 |
Daniel van Vugt |
compiz/0.9.8: milestone |
|
0.9.8.8 |
|
| 2013-01-03 06:13:47 |
Daniel van Vugt |
compiz/0.9.8: status |
New |
Fix Committed |
|
| 2013-01-03 06:13:54 |
Daniel van Vugt |
compiz: assignee |
|
Timo Jyrinki (timo-jyrinki) |
|
| 2013-01-03 06:14:02 |
Daniel van Vugt |
compiz/0.9.8: assignee |
|
Timo Jyrinki (timo-jyrinki) |
|
| 2013-01-03 06:14:11 |
Daniel van Vugt |
compiz-core: assignee |
|
Timo Jyrinki (timo-jyrinki) |
|
| 2013-01-03 06:14:17 |
Daniel van Vugt |
compiz (Ubuntu): assignee |
|
Timo Jyrinki (timo-jyrinki) |
|
| 2013-01-03 06:14:26 |
Daniel van Vugt |
compiz (Ubuntu Precise): assignee |
|
Timo Jyrinki (timo-jyrinki) |
|
| 2013-01-14 21:11:37 |
Launchpad Janitor |
compiz (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2013-01-24 12:03:51 |
Daniel van Vugt |
compiz: status |
Fix Committed |
Fix Released |
|
| 2013-03-26 02:59:21 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/precise-proposed/compiz |
|
| 2014-11-25 17:54:23 |
Stephen M. Webb |
compiz/0.9.8: status |
Fix Committed |
Fix Released |
|
| 2017-04-11 11:40:22 |
Timo Jyrinki |
compiz-core: status |
Fix Committed |
Fix Released |
|
