unable to use zope.recipe.zope2instance to add custom path lines to zope.conf

Bug #179610 reported by ken manheimer
4
Affects Status Importance Assigned to Milestone
collective.buildout
Status tracked in Trunk
Trunk
Fix Released
Undecided
Unassigned

Bug Description

i would like to do something similar to what is done for products in my buildout plone.recipe.zope2instance-based recipe, to supplement the zope.conf module paths. these paths are expressed with "path" lines in zope.conf, but i see no way to convey those settings from a buildout recipe. is it possible to do this? if so, how? if not, is there another way i'm supposed to be achieving my objective - to include a module in my built system that's not a zope product?

Revision history for this message
ken manheimer (ken-manheimer) wrote :

i'm attaching a patch that adds 'path' lines to the instance and zope client zope.conf files for each 'extra-paths' item in recipes that use plone.recipe.zope2instance. i hesitated to implement this change only because of uncertainty about using 'extra-paths' for this purpose. the paths designated there are also used to contribute to the paths in the control scripts, like plone.recipe.zope2instance.ctl. we *could* use a separate configuration variable name, like "module_paths", for this purpose - but i'm leaning towards thinking it's ok to reuse extra-paths this way.

this patch is against the trunk version, not the currently released (pypi) version. the latter would require an additional change to the zeo_conf_template like the one in the zope_conf_template.

Revision history for this message
ken manheimer (ken-manheimer) wrote :

any response to this fix?

Revision history for this message
Hanno Schlichting (hannosch) wrote :

The patch looks good to me. Can you apply it to the current trunk?

I just gave your plone.org user 'klm' checkin rights to the collective svn repo, so you don't have an excuse anymore to not commit this yourself ;)

Revision history for this message
ken manheimer (ken-manheimer) wrote :

> The patch looks good to me. Can you apply it to the current trunk?
>
> I just gave your plone.org user 'klm' checkin rights to the collective svn repo, so you don't have an excuse anymore to not commit this yourself ;)

:->

Excellent. Done. (Seeing that there was a 1.2 release, i added a section in CHANGES.txt for 1.3 and included the entry for my note about the change there - hope that was the right thing to do.)

Revision history for this message
Hanno Schlichting (hannosch) wrote :

Thx for the patch - version 1.3 is released now including this change.

Changed in collective.buildout:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.