plone.recipe.zope2instance zeo zope.conf neglects blob-storage setting

Bug #179113 reported by ken manheimer
8
Affects Status Importance Assigned to Milestone
collective.buildout
Fix Released
Undecided
Unassigned

Bug Description

when building a zeo client using plone.receipe.zope2instance, the zodb_db stanza disregards a buildout 'blob-storage' setting, generating a zodb.conf entry that looks like:

 <zodb_db main>
   mount-point /
   cache-size 5000
   <zeoclient>
     server 19100
     storage 1
     name zeostorage
     var /home/klm/Servers/PloneoutBlobs/parts/client1/var
     cache-size 30MB
   </zeoclient>
 </zodb_db>

supposing the blob-storage setting was /home/klm/Servers/PloneoutBlobs/var/blobstorage, that should be:

 <zodb_db main>
   mount-point /
   cache-size 5000
   <zeoclient>
     server 19100
     storage 1
     name zeostorage
     var /home/klm/Servers/PloneoutBlobs/parts/client1/var
     blob-storage /home/klm/Servers/PloneoutBlobs/var/blobstorage
     cache-size 30MB
   </zeoclient>
 </zodb_db>

Revision history for this message
LeoRochael (leorochael) wrote :
Revision history for this message
ken manheimer (ken-manheimer) wrote :

i can confirm that your version of plone.recipe.zope2instance resolves most of the problems i was seeing. the client's zope.conf has the correct blobstorage storage declaration. thanks!

there is one remaining problem. i include a "var =" setting in my [client1] and [client2] stanzas, expecting that would set the var directory in the <zodb_db><zeoclient> section of the resulting zope.conf, but that does not happen - the var setting continues to be the default.

Revision history for this message
Hanno Schlichting (hannosch) wrote :

There isn't a var option offered by the recipe at the moment.

Currently the template is hardcoded as "var %(instance_home)s/var". But we can probably add var as a new option default to the old hardcoded value.

Patches welcome ;)

Revision history for this message
Hanno Schlichting (hannosch) wrote :

While reviewing the changes I noticed that the branch removes the zeo_conf_template altogether. This results in the "zeo_client_name" option not to be included at all anymore. This needs to be fixed before I can merge the branch.

Revision history for this message
Hanno Schlichting (hannosch) wrote :

Copied over from https://bugs.launchpad.net/collective.buildout/+bug/179115:

On Dec 29, 2007 10:59 PM, Hanno Schlichting <email address hidden> wrote:
> In http://wiki.zope.org/ZODB/BlobsZeroCopy the blob-cache-writable
> zeo.conf option is mentioned which defaults to False and needs to be set
> to True in order to allow direct access from ZEO clients to the blob
> files.

BTW, in the actual configuration schema, this option has been renamed
to shared-blob-dir, and it's not a zeo.conf option, but a zope.conf
one (it's the client that has to be instructed not to stream the blob
over to the server).

I'll need this option, by the way, but I might not be able to get
around to it till a week from now. Other generous souls are welcome to
it.

Revision history for this message
LeoRochael (leorochael) wrote : Re: [Bug 179113] Re: plone.recipe.zope2instance zeo zope.conf neglects blob-storage setting

On Dec 29, 2007 11:17 PM, Hanno Schlichting <email address hidden> wrote:
> While reviewing the changes I noticed that the branch removes the
> zeo_conf_template altogether. This results in the "zeo_client_name"
> option not to be included at all anymore. This needs to be fixed before
> I can merge the branch.

Fixed

Revision history for this message
Hanno Schlichting (hannosch) wrote :

I merged the branch now and added the var and zeo-var options.

I'll wait for the 'shared-blob-dir' option to be added, before releasing a new version. This can be added directly to trunk now :)

Revision history for this message
LeoRochael (leorochael) wrote :

The originally reported issue has been fixed in the repository. New issue opened for the 'shared-blob-dir' option. Interested parties should subscribe to https://bugs.launchpad.net/collective.buildout/+bug/180861

Changed in collective.buildout:
status: New → Fix Committed
Revision history for this message
Hanno Schlichting (hannosch) wrote :

Fix for original issue is released now, thx!

Changed in collective.buildout:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.