Allow different names on SPEC URLs

[Eduardo Barretto]

I am not entirely sure if this is an issue in Mojo or Codetree, but when I specify the charms that should be collected, e.g.:

$ cat collect
canonical-livepatch cs:canonical-livepatch-37
bandersnatch git+ssh://git.launchpad.net/canonical-bandersnatch

The collect phase will fail as "bandersnatch" is not the "name" of the git repo (canonical-bandersnatch):
[ERROR] Codetree: bandersnatch is not a git repository

It only accepts the following:

$ cat collect
canonical-livepatch cs:canonical-livepatch-37
canonical-bandersnatch git+ssh://git.launchpad.net/canonical-bandersnatch

Giving a different "name" to the charm from charmstore works just fine

It would be great to "name" as you want.

If this is an issue in Mojo, feel free to update it :)

[Laurent Sesquès (sajoupa)]

Hi, I could not reproduce the issue:
ubuntu@mojo:~/spec$ cat collect
livepatch cs:canonical-livepatch-37
test bzr+ssh://bazaar.launchpad.net/~canonical-sysadmins/basenode/trunk
test2 git+ssh://<email address hidden>/postgresql-charm;revno=cs-postgresql-charmers-postgresql-8,overwrite=True
ubuntu@mojo:~/spec$ mojo collect --stage devel -p mojo-test -w mojo-test-workspace -s focal --spec-url ~/spec
2020-06-25 08:28:51 [INFO] Using pre-existing container class containerless
2020-06-25 08:28:51 [INFO] Rsyncing /home/ubuntu/spec to /home/ubuntu/.local/share/mojo/mojo-test/focal/mojo-test-workspace/spec
2020-06-25 08:28:51 [INFO] Building resource tree
2020-06-25 08:28:51 [INFO] Cloning repository at test2 from ssh://<email address hidden>/postgresql-charm
2020-06-25 08:28:51 [INFO] livepatch is up to date from url canonical-livepatch-37, skipping.
2020-06-25 08:28:55 [INFO] Pulling test from parent (bzr+ssh://bazaar.launchpad.net/~canonical-sysadmins/basenode/trunk)
2020-06-25 08:28:59 [INFO] test is at revno 109
2020-06-25 08:29:10 [INFO] Repository test2 at ref cs-postgresql-charmers-postgresql-8 revision eb2ef49a8435011bb8169002c0c7de1a6d67582c
2020-06-25 08:29:10 [INFO] Updating submodules in repository test2
2020-06-25 08:29:10 [INFO] Build a charm repository
2020-06-25 08:29:10 [INFO] Creating charm repo automatically from all charms in the build directory.
2020-06-25 08:29:10 [INFO] /home/ubuntu/.local/share/mojo/mojo-test/focal/mojo-test-workspace/build/livepatch => /home/ubuntu/.local/share/mojo/mojo-test/focal/mojo-test-workspace/charms/focal/livepatch (copy)
2020-06-25 08:29:10 [INFO] /home/ubuntu/.local/share/mojo/mojo-test/focal/mojo-test-workspace/build/test2 => /home/ubuntu/.local/share/mojo/mojo-test/focal/mojo-test-workspace/charms/focal/test2 (copy)
2020-06-25 08:29:10 [INFO] Completed collect phase in 19s (18.79s)

Could you give the version of mojo you're using, and how it was installed (deb or snap) ?
Full logs of the mojo run would be nice too.