SST donor logs an error (Invalid argument) even if SST was successful
Bug #415956 reported by
Alex Yurchenko
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MySQL patches by Codership |
Fix Released
|
Medium
|
Alex Yurchenko |
Bug Description
Log message:
090819 16:08:57 [Note] [DEBUG] WSREP: wsrep_sst_mysqldump complete: 22 (Invalid argument)
Offending code:
if (proc.error()) {
return -proc.error();
}
sql_
"[DEBUG] WSREP: wsrep_sst_mysqldump complete: %d (%s)",
errno, strerror(errno));
Apparently it reports a stray errno and it is moot.
Related branches
lp:~codership/codership-mysql/dev
(Merged)
Changed in codership-mysql: | |
assignee: | nobody → Alex Yurchenko (ayurchen) |
importance: | Undecided → Medium |
milestone: | none → 0.7 |
status: | New → In Progress |
Changed in codership-mysql: | |
status: | In Progress → Fix Committed |
Changed in codership-mysql: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
According to "The Open Group Base Specifications Issue 6 IEEE Std 1003.1, 2004 Edition":
"The value of errno should only be examined when it is indicated to be valid by a function's return value."
So using errno in the above code is wrong.