XEP-0202 Support

Bug #441223 reported by buzzdee
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released

Bug Description

As XEP-0202 (http://xmpp.org/extensions/xep-0202.html) is now a final standard, and more or less was everything prepared to support it, I enabled it.
However, I ran into the following problem:
I had two Coccinella clients running on the same box, the Local time shown in the Business Card window of the other User was two hours in the future. I am here in CEST, GMT+2 hours.

Enabling Debug level, I saw that the asked client sends out the information as specified by XEP-0202, using GMT and the Offset.
The receiving client did not correctly calculated the offset (fiddling around with GMT), the problem happend in jabber/Jabber.tcl in ::Jabber::GetEntityTimeString

I am not perfectly sure, whether this is the correct thing to fix the problem, I added a "-gmt 1" parameter to the output format. At least it worked for me with two clients on my notebook.

Further the jxmlns(entitytime) was set to "urn:xmpp:time" in jabberlib/jabberlib.tcl.

appended patch is doing that.

Revision history for this message
buzzdee (sebastia) wrote :
Changed in coccinella:
assignee: nobody → Coccinella (coccinella)
buzzdee (sebastia)
Changed in coccinella:
status: New → In Progress
Revision history for this message
buzzdee (sebastia) wrote :

I checked in svn revision #2743. This now enables the Entity Time.
The client sends out both: jabber:iq:time, and the newer urn:xmpp:time,
however, in case both return an answer, only the result of urn:xmpp:time is shown.
When urn:xmpp:time returns an error, the result of jabber:iq:time is shown

This also may need some more testing. Tested between two OpenBSD boxes,
having the timezone set to the same, and with differerent time zones.

Changed in coccinella:
status: In Progress → Fix Committed
Revision history for this message
sander (s-devrieze) wrote :

Did you checked compatibility with XEP-0202 and XEP-0082? Probably it is ok, but I am just asking.

Other remark: it seems the -gmt option is obsolete according to http://www.tcl.tk/man/tcl8.5/TclCmd/clock.htm#M19 Maybe the code should be rewritten using the -timezone option?

Revision history for this message
buzzdee (sebastia) wrote :

I have a printout of both XEPs next to me. If I did not misread anything it "should" conform to both.
answers received when requesting urn:xmpp:time this:
so looks fairly the same as in xep-0082 chapter 3.2.

Also just tested with requesting the time from a pidging xmpp client, I got a "not implemented" error message for xep-0202, and it fall back correctly to jabber:iq:time.

regarding the -gmt option, you are right, seems to be obsolete. However, it is used all over the place in the code. I think we should open a new bug report, and remove the usage of that option in all places?

Revision history for this message
buzzdee (sebastia) wrote :

regarding the -gmt option, created a separate bug report:

buzzdee (sebastia)
Changed in coccinella:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers