MIDI player not saved in preferences.rdb and volume is always 100% when opening preferences

Bug #427888 reported by buzzdee on 2009-09-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Coccinella
Status tracked in Trunk
Trunk
Medium
sander

Bug Description

I use Coccinella SVN on OpenBSD 4.5 with tcl/tk 8.5

with snack installed, then in the Preferences -> Sound configuration, when defining a MIDI player, the value is not saved to preferences.rdb file.

the appended patch fixes it for me.

I also just recognized that the volume is always at 100% when reopening the Preferences.
The line to set the value correctly (at least I guess so) was commented out. I updated previous patch to uncomment the line to take the gain value from the preferences.rdb file instead of always set it to 100%

buzzdee (sebastia) wrote :
buzzdee (sebastia) wrote :
description: updated
summary: - MIDI player not saved in preferences.rdb
+ MIDI player not saved in preferences.rdb and volume is always 100% when
+ opening preferences
buzzdee (sebastia) wrote :

I also just recognized the following:

when changing the midi player command, and then cancelling the preferences dialog, there no warning shows up.

adding the following to Sound.tcl to proc ::Sounds::CancelPrefsHook will create a warning when midiplayer was changed an cancel pressed:

    if {![string equal $sprefs(midiCmd) $tmpPrefs(midiCmd)]} {
        ::Preferences::HasChanged
    }

sander (s-devrieze) wrote :

Both fixes are committed, but what name and contact details should I add to the AUTHORS file with credits?

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers