coccinella crashes with user name 1 character long
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Coccinella |
Fix Released
|
High
|
Mats |
Bug Description
I cannot log in with a user name 1 character long (my JID is f@7f000001.org). The relevant piece of code
(from jabber/Login.tcl):
foreach name {server username password} {
upvar 0 $name var
if {[string length $var] <= 1} {
set mcname [mc [string totitle $nsme]]
return
}
if {$name eq "password"} {
}
# This is just to check the validity!
if {[catch {
switch -- $name {
}
}
}
} err]} {
return
}
}
<=1 should probably be changed to <1.
Moreover, there is a typo in
set mcname [mc [string totitle $nsme]]
(nsme should be name)
Changed in coccinella: | |
status: | Fix Committed → Fix Released |
it does not crashed on Mac OS X, but there indeed is a bug:
can't read "nsme": no such variable frall.f. b.btok invoke " frall.f. b.btok instate {pressed !disabled} { .jlogin. frall.f. b.btok state !pressed; .jlogin. frall.f. b.btok invoke } "
can't read "nsme": no such variable
while executing
"string totitle $nsme"
(procedure "::Login::DoLogin" line 30)
invoked from within
"::Login::DoLogin"
invoked from within
".jlogin.
invoked from within
".jlogin.
(command bound to event)
test account is 6@e.kernelpanic.cc
PS@Mats: e.kernelpanic.cc is running ejabberd 2.0 beta1 which supports sevral new XEPs and XEP versions...so you might be interested in that server for testing purposes ;-)