coccinella crashes with user name 1 character long

[michal hanula]

I cannot log in with a user name 1 character long (my JID is [e-mail]). The relevant piece of code
(from jabber/Login.tcl):

    foreach name {server username password} {
        upvar 0 $name var
        if {[string length $var] <= 1} {
            set mcname [mc [string totitle $nsme]]
            ::UI::MessageBox -icon error -title [mc Error] -type ok \
              -message [mc jamessnamemissing $mcname]
            return
        }
        if {$name eq "password"} {
            continue
        }

        # This is just to check the validity!
        if {[catch {
            switch -- $name {
                server {
                    jlib::nameprep $var
                }
                username {
                    jlib::nodeprep $var
                }
            }
        } err]} {
            ::UI::MessageBox -icon error -title [mc Error] -type ok \
              -message [mc jamessillegalchar $name $var]
            return
        }
    }

<=1 should probably be changed to <1.
Moreover, there is a typo in
    set mcname [mc [string totitle $nsme]]
(nsme should be name)

[sander (s-devrieze)]

it does not crashed on Mac OS X, but there indeed is a bug:

can't read "nsme": no such variable
can't read "nsme": no such variable
    while executing
"string totitle $nsme"
    (procedure "::Login::DoLogin" line 30)
    invoked from within
"::Login::DoLogin"
    invoked from within
".jlogin.frall.f.b.btok invoke "
    invoked from within
".jlogin.frall.f.b.btok instate {pressed !disabled} { .jlogin.frall.f.b.btok state !pressed; .jlogin.frall.f.b.btok invoke } "
    (command bound to event)

test account is [e-mail]

PS@Mats: e.kernelpanic.cc is running ejabberd 2.0 beta1 which supports sevral new XEPs and XEP versions...so you might be interested in that server for testing purposes ;-)

[michal hanula (f-7f000001)]

Sorry, I was not yet fully awake when reporting the bug. I get an error message (same one), coccinella does not crash.

[Mats (matsben)]

Many thanks for this one. I was too conservative in my checks, and didn't check it myself...