EnableCoverageReport macro does not append to target properties correctly

Bug #1469952 reported by James Henstridge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cmake-extras (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

In the EnableCoverageReport macro, the properties of various targets are altered with commands like:

    SET_PROPERTY(TARGET ${T} APPEND_STRING PROPERTY COMPILE_FLAGS "-g --coverage ")

If the target has its COMPILE_FLAGS set to e.g. "-foo", then this results in them being set to "-foo-g --coverage ", which results in a compile failure. If we are appending to the property, then there should be a space at the beginning of what we're appending. The space at the end seems superfluous though.

Related branches

Changed in cmake-extras:
status: New → In Progress
assignee: nobody → Michi Henning (michihenning)
Changed in cmake-extras:
status: In Progress → Fix Committed
Pete Woods (pete-woods)
no longer affects: cmake-extras
Pete Woods (pete-woods)
Changed in cmake-extras (Ubuntu):
status: New → In Progress
Pete Woods (pete-woods)
Changed in cmake-extras (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.