Fail to fallback to network_details v1 when not finding network details v2

[Adrian Vladu]

2018-10-03 13:34:52.165 3172 ERROR cloudbaseinit.init [-] plugin 'NetworkConfigPlugin' failed with error '': cloudbaseinit.metadata.services.base.NotExistingMetadataException
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init [-] : cloudbaseinit.metadata.services.base.NotExistingMetadataException
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init Traceback (most recent call last):
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init File "c:\program files\cloudbase solutions\cloudbase-init\python\lib\site-packages\cloudbaseinit\metadata\services\configdrive.py", line 80, in _get_data
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init with open(norm_path, 'rb') as stream:
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\CLOUDB~1\\AppData\\Local\\Temp\\tmpl7xhpm5o\\openstack\\latest\\network_data.json'
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init During handling of the above exception, another exception occurred:
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init Traceback (most recent call last):
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init File "c:\program files\cloudbase solutions\cloudbase-init\python\lib\site-packages\cloudbaseinit\init.py", line 67, in _exec_plugin
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init shared_data)
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init File "c:\program files\cloudbase solutions\cloudbase-init\python\lib\site-packages\cloudbaseinit\plugins\common\networkconfig.py", line 303, in execute
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init network_details = service.get_network_details_v2()
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init File "c:\program files\cloudbase solutions\cloudbase-init\python\lib\site-packages\cloudbaseinit\metadata\services\baseopenstackservice.py", line 241, in get_network_details_v2
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init network_data = self._get_network_data()
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init File "c:\program files\cloudbase solutions\cloudbase-init\python\lib\site-packages\cloudbaseinit\metadata\services\baseopenstackservice.py", line 68, in _get_network_data
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init return self._get_openstack_json_data(version, 'network_data.json')
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init File "c:\program files\cloudbase solutions\cloudbase-init\python\lib\site-packages\cloudbaseinit\metadata\services\baseopenstackservice.py", line 60, in _get_openstack_json_data
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init data = self._get_cache_data(path, decode=True)
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init File "c:\program files\cloudbase solutions\cloudbase-init\python\lib\site-packages\cloudbaseinit\metadata\services\base.py", line 76, in _get_cache_data
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init data = self._exec_with_retry(lambda: self._get_data(path))
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init File "c:\program files\cloudbase solutions\cloudbase-init\python\lib\site-packages\cloudbaseinit\metadata\services\base.py", line 59, in _exec_with_retry
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init return action()
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init File "c:\program files\cloudbase solutions\cloudbase-init\python\lib\site-packages\cloudbaseinit\metadata\services\base.py", line 76, in <lambda>
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init data = self._exec_with_retry(lambda: self._get_data(path))
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init File "c:\program files\cloudbase solutions\cloudbase-init\python\lib\site-packages\cloudbaseinit\metadata\services\configdrive.py", line 83, in _get_data
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init raise base.NotExistingMetadataException()
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init cloudbaseinit.metadata.services.base.NotExistingMetadataException
2018-10-03 13:34:52.181 3172 ERROR cloudbaseinit.init

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/607898
Committed: https://git.openstack.org/cgit/openstack/cloudbase-init/commit/?id=9bd096803e24091af294ea450d24d6b45fe9ff4b
Submitter: Zuul
Branch: master

commit 9bd096803e24091af294ea450d24d6b45fe9ff4b
Author: Adrian Vladu <email address hidden>
Date: Thu Oct 4 13:03:16 2018 +0300

    Fix get_network_details_v2 exception

    get_network_details_v2 implementation should be consistent with
    the base metadata service implementation.
    The method should return None in case the underlying metadata
    does not exist or if it is invalid.

    Change-Id: Ida3fe780f22dc20db6bd8ed3f43728a2671b46da
    Closes-Bug: #1796053