regression in test-growpart results in test fail device or resource busy

Bug #1842682 reported by Scott Moser on 2019-09-04
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-utils
High
Unassigned
cloud-utils (Ubuntu)
Medium
Unassigned
Disco
Medium
Rafael David Tinoco

Bug Description

This is a regression caused by the change for bug 1836593.

The change made in commit 51ef36d2281a38a65111995718e8ab85178438e5 [1] had broken/inverted logic that did the unmount only if the tracking variable 'MP' was empty.

In the hunk below, that should clearly check for '[ -n "$MP" ]'
+ if [ -z "$MP" ]; then
+ echo "unmount $MP";
+ umount "$MP";
+ udevadm settle
+ fi

--
[1] https://git.launchpad.net/cloud-utils/commit/?id=51ef36d2281a38a65111995718e8ab85178438e5

Related Bugs:
 * bug 1836593: race condition in dep 8 test

Related branches

Scott Moser (smoser) wrote :

This is actually *only* in disco-proposed.
No where else.

Changed in cloud-utils:
status: New → Confirmed
importance: Undecided → High
Scott Moser (smoser) on 2019-09-04
Changed in cloud-utils:
status: Confirmed → Fix Committed
Scott Moser (smoser) on 2019-09-04
Changed in cloud-utils (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cloud-utils - 0.31-5-gef42f6b5-0ubuntu1

---------------
cloud-utils (0.31-5-gef42f6b5-0ubuntu1) eoan; urgency=medium

  * New upstream snapshot.
    - test-growpart: fix logic error resulting in test failure.
      [Scott Moser] (LP: #1842682)
    - Fix race condition in test-growpart teardown seen on ppc64el.
      [Scott Moser] (LP: #1836593)

 -- Scott Moser <email address hidden> Wed, 04 Sep 2019 11:07:42 -0400

Changed in cloud-utils (Ubuntu):
status: In Progress → Fix Released

I confirm version 0.31-0ubuntu1.1 indeed fixes the issue.

Changed in cloud-utils (Ubuntu Disco):
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Rafael David Tinoco (rafaeldtinoco)
tags: added: verification-done verification-done-disco

Hello Scott, or anyone else affected,

Accepted cloud-utils into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-utils/0.31-0ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-disco
removed: verification-done verification-done-disco
Brian Murray (brian-murray) wrote :

This was not accepted into the -proposed pocket for Ubuntu until just now so I don't know why comment #3 modified the tags regarding verification but I'll undo that.

I have verified code from my own git ubuntu tree, and missed it wasn't in -proposed yet. I'll provide correct verification from pkgs in -proposed next. Thanks for fixing it Brian.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cloud-utils - 0.31-0ubuntu1.2

---------------
cloud-utils (0.31-0ubuntu1.2) disco; urgency=medium

  * test-growpart: fix logic error resulting in test failure.
    [Scott Moser] (LP: #1842682)

cloud-utils (0.31-0ubuntu1.1) disco; urgency=medium

  * fix race condition in test-growpart teardown seen on ppc64el (LP: #1836593)
  * growpart: fix bug when file image ends in a digit (LP: #1835124)
  * fix spelling error in ec2metadata (LP: #1810857)

 -- Rafael David Tinoco <email address hidden> Fri, 06 Sep 2019 10:47:23 -0300

Changed in cloud-utils (Ubuntu Disco):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for cloud-utils has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers