whitespace cleanups needed (tabs to spaces)

Bug #1836601 reported by Scott Moser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-utils
Invalid
Wishlist
Unassigned

Bug Description

When I started cloud-utils long ago, I was under the misguided view that tabs could be used reliably in source code. I have now accepted that without a machine formatted (go fmt) that is not the case.

An example can be seen in cloud-utils itself that has mixed tabs and spaces for indentation. smoser fail.

So, this bug is a request to:
a.) change tabs used for indentation to 4 spaces.
b.) change the vi modeline to be correct, and make sure it is present at the end of all files.
The correct modeline for 4 spaces indentation is:
   # vi: ts=4 expandtab

Note... if someone insists that the right fix is to remove modelines entirely [1] then I would accept that, but *something* needs to insist on consistent indentation, and I used vi modelines as a mechanism for declaring the style in a file.

--
[1] https://security.stackexchange.com/questions/36001/vim-modeline-vulnerabilities

Scott Moser (smoser)
Changed in cloud-utils:
status: New → Confirmed
Paride Legovini (paride)
Changed in cloud-utils:
status: Confirmed → Triaged
importance: Undecided → Wishlist
Revision history for this message
Paride Legovini (paride) wrote :
Changed in cloud-utils:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.